Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test fails when using RUST_NEW_ERROR_FORMAT #33763

Closed
sophiajt opened this issue May 21, 2016 · 2 comments
Closed

Test fails when using RUST_NEW_ERROR_FORMAT #33763

sophiajt opened this issue May 21, 2016 · 2 comments
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc

Comments

@sophiajt
Copy link
Contributor

If you set RUST_NEW_ERROR_FORMAT, running the full 'make check' will fail. @alexcrichton did some investigation and noticed this was one failure: https://github.com/rust-lang/rust/blob/master/src/test/run-make/unicode-input/span_length.rs#L94-L98

We may want to update the test or possibly move it to a UI test.
@sophiajt
Copy link
Contributor Author

cc @nikomatsakis

@nikomatsakis
Copy link
Contributor

Yeah, I think this is precisely what the UI testing is all about.

sophiajt pushed a commit to sophiajt/rust that referenced this issue May 24, 2016
Move issue-26480 cfail to ui test. Fix rust-lang#33763
9cc8deb
@sophiajt sophiajt mentioned this issue May 24, 2016
Merged
@apasel422 apasel422 added the A-testsuite Area: The testsuite used to check the correctness of rustc label May 26, 2016
Manishearth added a commit to Manishearth/rust that referenced this issue May 28, 2016
@Manishearth
Rollup merge of rust-lang#33820 - jonathandturner:format_readability_…
fe19b47 
…updates, r=nikomatsakis

Increase spacing in error format for readability.

Two small tweaks that seem to help readability quite a bit:
* Add spacing header<->snippet, but use the |> on the side for visual consistency
* Fix rust-lang#33819
* Fix rust-lang#33763
* Move format-sensitive test (issue-26480 in cfail) to ui test

r? @nikomatsakis
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nikomatsakis @sophiajt @apasel422