Skip to content

error::Error is not implemented for fmt::Error #33827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
burtonageo opened this issue May 23, 2016 · 8 comments
Closed

error::Error is not implemented for fmt::Error #33827

burtonageo opened this issue May 23, 2016 · 8 comments

Comments

@burtonageo
Copy link
Contributor

burtonageo commented May 23, 2016 •
edited
Loading

The Error trait is not implemented for the fmt::Error struct.
@GuillaumeGomez
Copy link
Member

Some source code would be appreciated. Context and rustc version as well.

@Stebalien
Copy link
Contributor

@GuillaumeGomez I think you're commenting on the wrong bug or misreading the issue. The issue here is that fmt::Error is an error and should implement error::Error but doesn't.

@GuillaumeGomez
Copy link
Member

@Stebalien: I think I went too fast, indeed. Now @burtonageo also added a description, which helps. :)

@GuillaumeGomez
Copy link
Member

I'm adding it btw.

@GuillaumeGomez GuillaumeGomez mentioned this issue May 24, 2016
Merged
Manishearth added a commit to Manishearth/rust that referenced this issue May 28, 2016
@Manishearth
Rollup merge of rust-lang#33856 - GuillaumeGomez:fmt_error, r=alexcri…
fe9a915 
…chton

Implement Error trait for fmt::Error type

Fixes rust-lang#33827.

r? @alexcrichton

Just one last thing: I added a feature name, but don't hesitate to ask me to change it if you think it doesn't fit well.
@pmarcelll
Copy link
Contributor

I looked around in the standard library's documentation, the only other case where error::Error is not implemented for an error is FromBytesWithNulError.

@GuillaumeGomez
Copy link
Member

@pmarcelll: Want to add it maybe? Take a look at my PR if you don't know how to do it.

@pmarcelll
Copy link
Contributor

Sure, I'll send a PR, but I'm busy currently, so only tomorrow.

@GuillaumeGomez
Copy link
Member

No problem. ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@Stebalien @burtonageo @pmarcelll @GuillaumeGomez @apasel422