Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add expected error code in code blocks flags #34168

Closed
GuillaumeGomez opened this issue Jun 8, 2016 · 0 comments
Closed

Add expected error code in code blocks flags #34168

GuillaumeGomez opened this issue Jun 8, 2016 · 0 comments

Comments

@GuillaumeGomez
Copy link
Member

Like debated recently with the (not official) doc team and @brson. I'm going to add the possibility to set an expected error code in block code flags for rustdoc check. The main purpose is to avoid that if an error code isn't throw anymore for a same code, it'll be updated in error code explanation as well.

So actually we have for example:

```compile_fail
// the failing code

With this change, it'll be possible to do:

```compile_fail,E0500
// the failing code

And if the E0500 error code isn't thrown at least once, then it'll fail.

It'll be gated of course. I'll start working on it in the next days.

cc @alexcrichton

bors added a commit that referenced this issue Jun 20, 2016
Implementation of #34168

r? @brson

cc @alexcrichton
cc @steveklabnik
cc @jonathandturner

I only updated `librustc_privacy/diagnostics.rs`, and I already found a case where the code doesn't throw the expected error code (E0448).

Fixes #34168.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant