Allow for disabling the stack check in a target file

[lambda-fairy]

In my use case (writing a kernel), I need to disable the stack overflow check. It would be nice if I could write

"stack-check": false

in my target file instead of manually passing -C no-stack-check to rustc.

[steveklabnik]

/cchttps://github.com//issues/16012

I forget if this flag works regardless if it's probes or not.

I am also not sure if there are other kernels who are turning this off; I know I'm not. Not that matters if it's what you need to do...

On Jun 14, 2016, 08:24 +0100, Chris Wongnotifications@github.com, wrote:

In my use case (writing a kernel), I need to disable the stack overflow check. It would be nice if I could write

"stack-check":false

in my target file instead of passing-C no-stack-checktorustc.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly,view it on GitHub(#34269), ormute the thread(https://github.com/notifications/unsubscribe/AABsiuicwsuVYWtGSmINThhXFNJNtisvks5qLlcfgaJpZM4I1B_Y).

[lambda-fairy]

Ooh, I did some more searching and realized that -C no-stack-check doesn't actually do anything today.

Since #27338 removed the morestack stuff, and stack probes haven't arrived yet, there isn't really a "stack check" to disable in the first place. And when stack probes land, they'll be harmless for osdev.

@steveklabnik Is that why your project doesn't use that flag? I was operating under the assumption that -C no-stack-check is necessary for freestanding projects, but if that's false then I can close this issue right away.

[steveklabnik]

That was my hunch, but I wasn't sure. So I'm guessing that is true.

On Jun 14, 2016, 11:32 +0100, Chris Wongnotifications@github.com, wrote:

Ooh, I did some more searching and realized that-C no-stack-checkdoesn't actually do anything today.

Since#27338(#27338 the morestack stuff, and stack probes haven't arrived yet, there isn't really a "stack check" to disable in the first place. And when stack probes land, they'll be harmless for osdev.

@steveklabnik(https://github.com/steveklabnik)Is that why your project doesn't use that flag? I was operating under the assumption that-C no-stack-checkis necessary for freestanding projects, but if that's false then I can close this issue right away.

—
You are receiving this because you were mentioned.
Reply to this email directly,view it on GitHub(#34269 (comment)), ormute the thread(https://github.com/notifications/unsubscribe/AABsitnoI6rodWdawAAmvYxboFqkSSrpks5qLoNDgaJpZM4I1B_Y).

[lambda-fairy]

Okay, since I don't really have a use case for it now I'm going to close the issue.