Skip to content

RFC: Remove "unchecked" blocks #3436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pcwalton opened this issue Sep 10, 2012 · 5 comments
Closed

RFC: Remove "unchecked" blocks #3436

pcwalton opened this issue Sep 10, 2012 · 5 comments
Assignees
Labels
A-type-system Area: Type system
Milestone

Comments

@pcwalton
Copy link
Contributor

Unchecked blocks can be used to write reinterpret_cast, which can cast an unsafe function to a safe one and call it. Thus there's no real difference between an unchecked block and an unsafe block. So I propose removing unchecked from the language.

@brson
Copy link
Contributor

brson commented Sep 10, 2012

I agree. Maybe later we can improve unsafe with additional effects, but two keywords here is extravagant.

@nikomatsakis
Copy link
Contributor

+1

@catamorphism
Copy link
Contributor

Agreed. The distinction between unchecked and unsafe blocks is one we don't need (we have enough confusion as it is), even if the distinction were more meaningful.

@ghost ghost assigned brson Sep 12, 2012
@graydon
Copy link
Contributor

graydon commented Sep 12, 2012

Agreed. There was consensus on this at the meeting, I believe. I'm assigning (tentatively) to @brson as part of the keyword-removal bug for 0.4; if it winds up taking much more work than merging the two keywords and the paths that check one vs. the other in the semantic checks, punt back to 0.5 or such. But I think this is near-term.

@brson
Copy link
Contributor

brson commented Sep 18, 2012

Done.

@brson brson closed this as completed Sep 18, 2012
RalfJung pushed a commit to RalfJung/rust that referenced this issue Mar 31, 2024
speed up Windows CI

The many-seeds test is taking 15 minutes. Let's just run that only once instead of many times on Windows.

Also refactor the CI script to make the caller control which tests are being run.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-type-system Area: Type system
Projects
None yet
Development

No branches or pull requests

5 participants