Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libstd: Some fs tests check localized error messages and fail on non-English versions of Windows #34628

Closed
petrochenkov opened this issue Jul 3, 2016 · 1 comment

Comments

@petrochenkov
Copy link
Contributor

The tests in question:

fs::tests::file_test_iounlinking_invalid_path_should_raise_condition
fs::tests::invalid_path_raises
fs::tests::open_flavors

They check that the error messages from OS contain the string "The parameter is incorrect" literally, but on non-English OS versions the error messages are translated.

cc @pitdicker @alexcrichton
Feel free to close this issue if the fix is non-trivial, this is only a minor inconvenience - make check fails and the tests have to be skipped manually by touching tmp/check-stage2-T-x86_64-pc-windows-gnu-H-x86_64-pc-windows-gnu-std.ok.

@retep998
Copy link
Member

retep998 commented Jul 3, 2016

It would be better if we checked the error code itself rather than analyzing the string, at least on Windows anyway where error codes are standardized. Should be a simple fix and I could mentor if someone wanted it.

bors added a commit that referenced this issue Dec 26, 2016
Fix fs tests on Windows systems with non-english locales.

Fixes #34628

r? @alexcrichton
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants