-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Rename ARC to Arc #3491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
really? :\ I picked it that way 'cause it's an acronym. RWARC too. I guess it could stand to be RWArc. It might do to have an entirely new name - "arc" has always felt kind of researcher-speak-y. Maybe SharedState for ARC, SharedMutableState for MutexARC, and RWSharedState for RWARC. |
I usually prefer to not do allcaps acronyms with camel case, like |
the thing i was afraid of when i camelcased the arc module was that someone else would come along before me and write |
+1 for something involving "shared", and get rid of the "arc" moniker altogether. Perhaps |
(keeping in mind that |
Involving I dunno, though. The more I think about it (while writing blog posts about it) the more I like how concise ARC and RWARC are as typenames. They take a while to understand, but they don't have the AbstractSingletonProxyFactoryBean problem. I like the idea that the sort of "primitive" concurrency types have snappy names - task, pipe, port, chan, arc, rwarc... |
How about just |
I'm a fan of |
I think |
I'd happily try and tackle the renames (ARC => Arc / RWARC => RWArc / MutexARC => MutexArc) if you can agree that this is the best? It seems like no other wording can be clear enough without being overly verbose. I personally like that ARC is weird enough that it forces you to look up what it means, but then it's quite memorable. I think it would be good to fix them for consistency with other things (IpAddr, Url to name a few), because it's a pain when the case isn't consistently guessable. That said, on the topic of consistency, I also see stuff like extra::sync::RWlock which should be RWLock if we follow this pattern I suppose? Similarly extra::sync::semaphore sounds like it should be Semaphore to me but maybe I'm missing something? |
I personally prefer ARC to Arc, although it seems like our conventions have been shifting toward the initial-caps-only pattern overall, and it wouldn't be so bad. I definitely agree with preferring it to be memorable than autological. The |
@bblum: I think |
I dunno. That sounds ok at first, but then you'll wind up with RWAtomicRc and MutexAtomicRc, which are getting into the "too afraid of scaring beginners away that our type names turn ugly" territory for my (personal, subjective) taste. I feel moderately strongly that ARC and RWARC are iconic. |
this is done now |
Super. |
Arc's are yelling at me.
The text was updated successfully, but these errors were encountered: