Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The check against LLVM's data-layout needs to be relaxed/updated #34960

Closed
alexcrichton opened this issue Jul 21, 2016 · 2 comments
Closed

The check against LLVM's data-layout needs to be relaxed/updated #34960

alexcrichton opened this issue Jul 21, 2016 · 2 comments

Comments

@alexcrichton
Copy link
Member

Discovered in #34743, LLVM's data layouts are changing over time. If we assert that our own data layout agrees with LLVM's then if we change to a newer LLVM we break compatibility with older LLVMs. It looks like the change to the data layout was backwards compatible, I think, so we probably just need a different check here.

cc @eddyb

@eddyb
Copy link
Member

eddyb commented Jul 21, 2016

Previous thoughts at #33446, but that never materialized.

@Mark-Simulacrum
Copy link
Member

Yeah, I'm going to close in favor of #33446 and leave a comment there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants