Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

atomic-lock-free test doesn't account for LLVM support #35023

Closed
cuviper opened this issue Jul 25, 2016 · 3 comments
Closed

atomic-lock-free test doesn't account for LLVM support #35023

cuviper opened this issue Jul 25, 2016 · 3 comments

Comments

@cuviper
Copy link
Member

cuviper commented Jul 25, 2016

In run-make/atomic-lock-free/Makefile, it attempts to build its script for many different architectures. However, when using an external LLVM build, it may not have all architectures available, so the test will fail despite anything Rust could do. For example, on Fedora 24 I have:

$ llvm-config --targets-built
X86 AMDGPU PowerPC NVPTX SystemZ AArch64 ARM BPF CppBackend

In particular this doesn't have "Mips", so the mips and mipsel targets will fail in atomic-lock-free. It would be nicer if this test only attempted architectures that are included in one's build of LLVM.

@nagisa
Copy link
Member

nagisa commented Jul 25, 2016

See #34962 (that would be a first step to fix the issue).

Rustc currently requires LLVM to support x86, aarch64, arm, mips, powerpc and nacl targets. You cannot omit any of these unless you patch rustc code in various places.

@sanxiyn
Copy link
Member

sanxiyn commented Jul 25, 2016

We "sort of" support LLVM configured with different targets since #27937. It is not the case we don't have any code to support that use case.

@cuviper
Copy link
Member Author

cuviper commented Jul 25, 2016

Thanks for the links.

@nagisa Where else would you expect problems? I found the entire "make check" was fine except for this one atomic-lock-free test.

Anyway, Fedora's LLVM maintainers agreed to add "Mips" next time they rebuild, so I guess this isn't a huge issue for me. But if Rust ever decides to add another "required" target, it would be good to understand how urgent that is to comply.

Manishearth added a commit to Manishearth/rust that referenced this issue Sep 10, 2016
…hton

Use LLVM_COMPONENTS to run tests just for supported targets

This is already done for simd-ffi test, but not for atomic-lock-free test.

Fix rust-lang#35023.
bors added a commit that referenced this issue Sep 12, 2016
Use LLVM_COMPONENTS to run tests just for supported targets

This is already done for simd-ffi test, but not for atomic-lock-free test.

Fix #35023.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants