-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
atomic-lock-free test doesn't account for LLVM support #35023
Comments
See #34962 (that would be a first step to fix the issue). Rustc currently requires LLVM to support |
We "sort of" support LLVM configured with different targets since #27937. It is not the case we don't have any code to support that use case. |
Thanks for the links. @nagisa Where else would you expect problems? I found the entire "make check" was fine except for this one Anyway, Fedora's LLVM maintainers agreed to add "Mips" next time they rebuild, so I guess this isn't a huge issue for me. But if Rust ever decides to add another "required" target, it would be good to understand how urgent that is to comply. |
…hton Use LLVM_COMPONENTS to run tests just for supported targets This is already done for simd-ffi test, but not for atomic-lock-free test. Fix rust-lang#35023.
Use LLVM_COMPONENTS to run tests just for supported targets This is already done for simd-ffi test, but not for atomic-lock-free test. Fix #35023.
In
run-make/atomic-lock-free/Makefile
, it attempts to build its script for many different architectures. However, when using an external LLVM build, it may not have all architectures available, so the test will fail despite anything Rust could do. For example, on Fedora 24 I have:In particular this doesn't have "Mips", so the
mips
andmipsel
targets will fail inatomic-lock-free
. It would be nicer if this test only attempted architectures that are included in one's build of LLVM.The text was updated successfully, but these errors were encountered: