Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a test for AddAssign on String #35047

Closed
bstrie opened this issue Jul 26, 2016 · 2 comments
Closed

Add a test for AddAssign on String #35047

bstrie opened this issue Jul 26, 2016 · 2 comments
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-needs-test Call for participation: An issue has been fixed and does not reproduce, but no test has been added.

Comments

@bstrie
Copy link
Contributor

bstrie commented Jul 26, 2016

#34890 was merged, but it should have had an accompanying test.
@bstrie bstrie added E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-needs-test Call for participation: An issue has been fixed and does not reproduce, but no test has been added. labels Jul 26, 2016
@munyari
Copy link
Contributor

munyari commented Jul 26, 2016

I would like to take this on

@knight42 knight42 mentioned this issue Jul 26, 2016
Merged
@knight42
Copy link
Contributor

@munyari I am working on this now

steveklabnik added a commit to steveklabnik/rust that referenced this issue Jul 30, 2016
@steveklabnik
Rollup merge of rust-lang#35049 - knight42:add-test, r=alexcrichton
bb01409 
Add a test for AddAssign on String

Fix rust-lang#35047
Manishearth added a commit to Manishearth/rust that referenced this issue Jul 30, 2016
@Manishearth
Rollup merge of rust-lang#35049 - knight42:add-test, r=alexcrichton
96e3972 
Add a test for AddAssign on String

Fix rust-lang#35047
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-needs-test Call for participation: An issue has been fixed and does not reproduce, but no test has been added.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bstrie @knight42 @munyari