Skip to content

Remove class-related code from the compiler #3515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
brson opened this issue Sep 17, 2012 · 4 comments
Closed

Remove class-related code from the compiler #3515

brson opened this issue Sep 17, 2012 · 4 comments
Labels
A-frontend Area: Compiler frontend (errors, parsing and HIR) C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Milestone

Comments

@brson
Copy link
Contributor

brson commented Sep 17, 2012

Classes no longer parse all the features they used to have, but they are still represented in the AST.

@ghost ghost assigned brson Sep 17, 2012
@nikomatsakis
Copy link
Contributor

Also: there is a lot of complexity in liveness to handle constructors
that is no longer needed

@catamorphism
Copy link
Contributor

Looks like 98887cc did this. Closing.

@brson
Copy link
Contributor Author

brson commented Dec 7, 2012

I still see lots of gunk in ast::struct_def. This is the current definition:

1486:type struct_def = {
1487-    traits: ~[@trait_ref],   /* traits this struct implements */
1488-    fields: ~[@struct_field], /* fields */
1489-    methods: ~[@method],    /* methods */
1490-    /* (not including ctor or dtor) */
1491-    /* dtor is optional */
1492-    dtor: Option<class_dtor>,
1493-    /* ID of the constructor. This is only used for tuple- or enum-like
1494-     * structs. */
1495-    ctor_id: Option<node_id>
1496-};

@brson brson reopened this Dec 7, 2012
@catamorphism
Copy link
Contributor

I think I've removed everything now. If you find something else, reopen.

bors pushed a commit to rust-lang-ci/rust that referenced this issue May 15, 2021
RalfJung pushed a commit to RalfJung/rust that referenced this issue Apr 27, 2024
RalfJung pushed a commit to RalfJung/rust that referenced this issue Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-frontend Area: Compiler frontend (errors, parsing and HIR) C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Development

No branches or pull requests

3 participants