Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E0029 needs to be updated to new format #35201

Closed
sophiajt opened this issue Aug 2, 2016 · 1 comment
Closed

E0029 needs to be updated to new format #35201

sophiajt opened this issue Aug 2, 2016 · 1 comment
Labels
A-diagnostics Area: Messages for errors, warnings, and lints E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.

Comments

@sophiajt
Copy link
Contributor

sophiajt commented Aug 2, 2016

From: src/test/compile-fail/E0029.rs

The E0029 error needs a span_label, taking it from:

error[E0029]: only char and numeric types are allowed in range patterns
 start type: &'static str
 end type: &'static str
  --> src/test/compile-fail/E0029.rs:15:9
   |
15 |         "hello" ... "world" => {} //~ ERROR E0029
   |         ^^^^^^^^^^^^^^^^^^^

to:

error[E0029]: only char and numeric types are allowed in range patterns
 start type: &'static str
 end type: &'static str
  --> src/test/compile-fail/E0029.rs:15:9
   |
15 |         "hello" ... "world" => {} //~ ERROR E0029
   |         ^^^^^^^^^^^^^^^^^^^ ranges require char or numeric types

Bonus: The start type and end type should probably be added as notes to the error rather than part of the main message text, something like:

error[E0029]: only char and numeric types are allowed in range patterns
  --> src/test/compile-fail/E0029.rs:15:9
   |
15 |         "hello" ... "world" => {} //~ ERROR E0029
   |         ^^^^^^^^^^^^^^^^^^^ ranges require char or numeric types
   |
   = note: starting type is &'static str
   = note: ending type is &'static str
@sophiajt sophiajt added E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. A-diagnostics Area: Messages for errors, warnings, and lints E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. and removed E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. labels Aug 2, 2016
sophiajt pushed a commit to sophiajt/rust that referenced this issue Aug 6, 2016
…andturner

Update compiler error 0029 to use new error format.

Part of rust-lang#35233,
Addresses rust-lang#35201

r? @jonathandturner
sophiajt pushed a commit to sophiajt/rust that referenced this issue Aug 7, 2016
…andturner

Update compiler error 0029 to use new error format.

Part of rust-lang#35233,
Addresses rust-lang#35201

r? @jonathandturner
sophiajt pushed a commit to sophiajt/rust that referenced this issue Aug 7, 2016
…andturner

Update compiler error 0029 to use new error format.

Part of rust-lang#35233,
Addresses rust-lang#35201

r? @jonathandturner
sophiajt pushed a commit to sophiajt/rust that referenced this issue Aug 7, 2016
…andturner

Update compiler error 0029 to use new error format.

Part of rust-lang#35233,
Addresses rust-lang#35201

r? @jonathandturner
@KiChjang
Copy link
Member

KiChjang commented Aug 8, 2016

Should be fixed by #35413.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-diagnostics Area: Messages for errors, warnings, and lints E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.
Projects
None yet
Development

No branches or pull requests

2 participants