Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E0076 needs to be updated to new format #35221

Closed
sophiajt opened this issue Aug 2, 2016 · 3 comments
Closed

E0076 needs to be updated to new format #35221

sophiajt opened this issue Aug 2, 2016 · 3 comments
Labels
A-diagnostics Area: Messages for errors, warnings, and lints E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.

Comments

@sophiajt
Copy link
Contributor

sophiajt commented Aug 2, 2016

From: src/test/compile-fail/E0076.rs

Error E0076 needs a span_label, updating it from:

error[E0076]: SIMD vector should be homogeneous
  --> src/test/compile-fail/E0076.rs:14:1
   |
14 | struct Bad(u16, u32, u32); //~ ERROR E0076
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^

To:

error[E0076]: SIMD vector should be homogeneous
  --> src/test/compile-fail/E0076.rs:14:1
   |
14 | struct Bad(u16, u32, u32); //~ ERROR E0076
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^ SIMD elements must have the same type

Bonus: The span should focus on the arguments

error[E0076]: SIMD vector should be homogeneous
  --> src/test/compile-fail/E0076.rs:14:1
   |
14 | struct Bad(u16, u32, u32); //~ ERROR E0076
   |            ^^^^^^^^^^^^^ SIMD elements must have the same type
@sophiajt sophiajt added E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. A-diagnostics Area: Messages for errors, warnings, and lints E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. labels Aug 2, 2016
@abhiQmar
Copy link
Contributor

abhiQmar commented Aug 27, 2016

I have updated the message to show after span. All tests are passing.
Figuring out how to make span point to the parameters only. Any suggestion is welcome.

ps Running test-suite almost burned up the back of my laptop 😂

@sophiajt
Copy link
Contributor Author

sophiajt commented Aug 27, 2016

@abhiQmar - sadly, some of the bonuses don't have enough information in the compiler to be completed. I looked around and wasn't able to find an easy way to get this span information.

Please feel free to submit without the bonus and I'll close the bonus part as not easily possible for now.

@abhiQmar
Copy link
Contributor

@jonathandturner Thanks for your help on this. I have submitted without the bonus, please review.

abhiQmar added a commit to abhiQmar/rust that referenced this issue Aug 30, 2016
sophiajt pushed a commit to sophiajt/rust that referenced this issue Aug 30, 2016
…andturner

Update compiler error E0076 to use new error format

Fixes rust-lang#35221 part of rust-lang#35233

r? @jonathandturner
sophiajt pushed a commit to sophiajt/rust that referenced this issue Aug 31, 2016
…andturner

Update compiler error E0076 to use new error format

Fixes rust-lang#35221 part of rust-lang#35233

r? @jonathandturner
sophiajt pushed a commit to sophiajt/rust that referenced this issue Aug 31, 2016
…andturner

Update compiler error E0076 to use new error format

Fixes rust-lang#35221 part of rust-lang#35233

r? @jonathandturner
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-diagnostics Area: Messages for errors, warnings, and lints E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.
Projects
None yet
Development

No branches or pull requests

2 participants