Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

E0080 needs better wording #35223

Closed
sophiajt opened this issue Aug 2, 2016 · 2 comments
Closed

E0080 needs better wording #35223

sophiajt opened this issue Aug 2, 2016 · 2 comments
Labels
A-diagnostics Area: Messages for errors, warnings, and lints E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.

Comments

@sophiajt
Copy link
Contributor

sophiajt commented Aug 2, 2016 •
edited
Loading

From: src/test/compile-fail/E0080.rs

Error E0080 has been updated to the new format, but its wording is awkward. It can be updated from:

error[E0080]: constant evaluation error
  --> src/test/compile-fail/E0080.rs:12:9
   |
12 |     X = (1 << 500), //~ ERROR E0080
   |         ^^^^^^^^^^ attempted to shift left with overflow

error[E0080]: constant evaluation error
  --> src/test/compile-fail/E0080.rs:13:9
   |
13 |     Y = (1 / 0) //~ ERROR E0080
   |         ^^^^^^^ attempted to divide by zero

To:

error[E0080]: constant evaluation error
  --> src/test/compile-fail/E0080.rs:12:9
   |
12 |     X = (1 << 500), //~ ERROR E0080
   |         ^^^^^^^^^^ attempt to shift left with overflow

error[E0080]: constant evaluation error
  --> src/test/compile-fail/E0080.rs:13:9
   |
13 |     Y = (1 / 0) //~ ERROR E0080
   |         ^^^^^^^ attempt to divide by zero
@sophiajt sophiajt added E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. A-diagnostics Area: Messages for errors, warnings, and lints E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. labels Aug 2, 2016
@GuillaumeGomez GuillaumeGomez mentioned this issue Aug 3, 2016
Closed
@shantanuraj shantanuraj mentioned this issue Aug 4, 2016
Merged
@shantanuraj
Copy link
Contributor

Created a pull request #35283

bors added a commit that referenced this issue Aug 5, 2016
@bors
Auto merge of #35283 - shantanuraj:master, r=jonathandturner
41fe4b7 
Update wording on E0080

Part of #35223

Update wording on error E0080. Change "attempted" to "attempt"

r? @GuillaumeGomez
@KiChjang
Copy link
Member

KiChjang commented Aug 8, 2016

Should be fixed by #35283.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-diagnostics Area: Messages for errors, warnings, and lints E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sophiajt @shantanuraj @KiChjang