Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

E0121 needs to be updated to new format #35254

Closed
sophiajt opened this issue Aug 3, 2016 · 1 comment
Closed

E0121 needs to be updated to new format #35254

sophiajt opened this issue Aug 3, 2016 · 1 comment
Labels
A-diagnostics Area: Messages for errors, warnings, and lints E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.

Comments

@sophiajt
Copy link
Contributor

sophiajt commented Aug 3, 2016

From: src/test/compile-fail/E0121.rs

Error E0121 needs a span_label, updating it from:

error[E0121]: the type placeholder `_` is not allowed within types on item signatures
  --> src/test/compile-fail/E0121.rs:11:13
   |
11 | fn foo() -> _ { 5 } //~ ERROR E0121
   |             ^

error[E0121]: the type placeholder `_` is not allowed within types on item signatures
  --> src/test/compile-fail/E0121.rs:13:13
   |
13 | static BAR: _ = "test"; //~ ERROR E0121
   |             ^

To:

error[E0121]: the type placeholder `_` is not allowed within types on item signatures
  --> src/test/compile-fail/E0121.rs:11:13
   |
11 | fn foo() -> _ { 5 } //~ ERROR E0121
   |             ^ not allowed in type signatures

error[E0121]: the type placeholder `_` is not allowed within types on item signatures
  --> src/test/compile-fail/E0121.rs:13:13
   |
13 | static BAR: _ = "test"; //~ ERROR E0121
   |             ^ not allowed in type signatures
@sophiajt sophiajt added E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. A-diagnostics Area: Messages for errors, warnings, and lints E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. labels Aug 3, 2016
@GuillaumeGomez GuillaumeGomez mentioned this issue Aug 3, 2016
Closed
@intrepion
Copy link
Contributor

I'd like to take this

@intrepion intrepion mentioned this issue Aug 6, 2016
Merged
sophiajt pushed a commit to sophiajt/rust that referenced this issue Aug 7, 2016
Rollup merge of rust-lang#35434 - intrepion:fix-compile-fail-e0121, r…
c150ce6 
…=jonathandturner

Fixing compiler error E0121

Fixes rust-lang#35254 and part of rust-lang#35233
sophiajt pushed a commit to sophiajt/rust that referenced this issue Aug 7, 2016
Rollup merge of rust-lang#35434 - intrepion:fix-compile-fail-e0121, r…
f04b440 
…=jonathandturner

Fixing compiler error E0121

Fixes rust-lang#35254 and part of rust-lang#35233
sophiajt pushed a commit to sophiajt/rust that referenced this issue Aug 7, 2016
Rollup merge of rust-lang#35434 - intrepion:fix-compile-fail-e0121, r…
87e129e 
…=jonathandturner

Fixing compiler error E0121

Fixes rust-lang#35254 and part of rust-lang#35233
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-diagnostics Area: Messages for errors, warnings, and lints E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sophiajt @intrepion