Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E0185 needs to be updated to new format #35276

Closed
sophiajt opened this issue Aug 4, 2016 · 1 comment
Closed

E0185 needs to be updated to new format #35276

sophiajt opened this issue Aug 4, 2016 · 1 comment
Labels
A-diagnostics Area: Messages for errors, warnings, and lints E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.

Comments

@sophiajt
Copy link
Contributor

sophiajt commented Aug 4, 2016

From: src/test/compile-fail/E0185.rs

E0185 needs a span_label, updating it from:

error[E0185]: method `foo` has a `&self` declaration in the impl, but not in the trait
  --> src/test/compile-fail/E0185.rs:18:5
   |
18 |     fn foo(&self) {} //~ ERROR E0185
   |     ^^^^^^^^^^^^^^^^

To:

error[E0185]: method `foo` has a `&self` declaration in the impl, but not in the trait
  --> src/test/compile-fail/E0185.rs:18:5
   |
18 |     fn foo(&self) {} //~ ERROR E0185
   |     ^^^^^^^^^^^^^^^^ `&self` not used in the trait

Bonus: show the trait that it's referencing.

error[E0185]: method `foo` has a `&self` declaration in the impl, but not in the trait
  --> src/test/compile-fail/E0185.rs:18:5
   |
12 |     fn foo();
   |     --------- trait declared without `&self`
...
18 |     fn foo(&self) {} //~ ERROR E0185
   |     ^^^^^^^^^^^^^^^^ `&self` used in impl
@sophiajt sophiajt added E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. A-diagnostics Area: Messages for errors, warnings, and lints E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. labels Aug 4, 2016
@yossi-k
Copy link
Contributor

yossi-k commented Aug 4, 2016

On it

sophiajt pushed a commit to sophiajt/rust that referenced this issue Aug 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-diagnostics Area: Messages for errors, warnings, and lints E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.
Projects
None yet
Development

No branches or pull requests

2 participants