Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

long diagnostics not registered for some internal crates #35284

Closed
zackmdavis opened this issue Aug 4, 2016 · 2 comments
Closed

long diagnostics not registered for some internal crates #35284

zackmdavis opened this issue Aug 4, 2016 · 2 comments

Comments

@zackmdavis
Copy link
Member

In the comments on #32777, @jhod0 writes:

I looked into it more, and it looks like the following libraries' long error messages are not properly registered:

  • libsyntax
  • librustc_passes
  • librustc_plugin
    • However, the register_long_diagnostics! declaration in librustc_plugin is empty
  • librustc_mir
  • librustc_lint
  • librustc_metadata

i.e. running the following for any errno in the above libraries will fail:

$ rustc --explain <errno>
error: no extended information for <errno>
@jhod0
Copy link

jhod0 commented Aug 9, 2016

@zackmdavis ok, I'll work on a PR

It's a little more complicated than just linking those errors, because linking those errors exposes some failing doctests that need to be fixed.

Fortunately, there aren't all that many error explanations in these crates, and therefore Rust users are not currently missing all that much from them.

@Mark-Simulacrum
Copy link
Member

Today, I think just src/librustc_mir/diagnostics.rs and src/libsyntax/diagnostic_list.rs aren't picked up. Either way, closing in favor of #34588 and adding a note there.

zackmdavis added a commit to zackmdavis/rust that referenced this issue Aug 7, 2017
Bizarrely, librustc_passes, librustc_plugin, librustc_mir, and libsyntax
weren't getting their error explanations registered.

Resolves rust-lang#35284.
bors added a commit that referenced this issue Aug 7, 2017
…uillaumeGomez

de-orphan extended information

Bizarrely, librustc_passes, librustc_plugin, librustc_mir, and libsyntax [weren't getting their error explanations registered](#35284) (leaving _several_ error codes absent from [the index](https://doc.rust-lang.org/nightly/error-index.html) and `--explain`). This surfaced a few latent doctest failures that were fixed where readily possible and ignored (with a recorded excuse) if not.

Also, we don't issue E0563 anymore.

r? @GuillaumeGomez
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants