Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E0322 needs to be updated to new format #35323

Closed
sophiajt opened this issue Aug 4, 2016 · 2 comments
Closed

E0322 needs to be updated to new format #35323

sophiajt opened this issue Aug 4, 2016 · 2 comments
Labels
A-diagnostics Area: Messages for errors, warnings, and lints E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.

Comments

@sophiajt
Copy link
Contributor

sophiajt commented Aug 4, 2016

From: src/test/compile-fail/coherence-impls-sized.rs

Error E0322 needs a span_label, updating it from:

error[E0322]: explicit impls for the `Sized` trait are not permitted
  --> src/test/compile-fail/coherence-impls-sized.rs:24:1
   |
24 | impl Sized for TestE {} //~ ERROR E0322
   | ^^^^^^^^^^^^^^^^^^^^^^^

To:

error[E0322]: explicit impls for the `Sized` trait are not permitted
  --> src/test/compile-fail/coherence-impls-sized.rs:24:1
   |
24 | impl Sized for TestE {} //~ ERROR E0322
   | ^^^^^^^^^^^^^^^^^^^^^^^ impl of `Sized` not allowed

Bonus: shrink the span to only the Sized part:

error[E0322]: explicit impls for the `Sized` trait are not permitted
  --> src/test/compile-fail/coherence-impls-sized.rs:24:1
   |
24 | impl Sized for TestE {} //~ ERROR E0322
   |      ^^^^^ impl of `Sized` not allowed
@sophiajt sophiajt added E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. A-diagnostics Area: Messages for errors, warnings, and lints E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. labels Aug 4, 2016
@tvladyslav
Copy link
Contributor

Hi! I'd like to contribute. It will be my first pull request. May I take this issue?

@sophiajt
Copy link
Contributor Author

sophiajt commented Aug 8, 2016

@crypto-universe - Looks like this one is currently set to: @yossi-k. I'll let them chime in here if they want to take this one or not.

There's a list here: #35233 where you can see which ones are free. I just added more if you want to grab a free one.

sophiajt pushed a commit to sophiajt/rust that referenced this issue Aug 15, 2016
sophiajt pushed a commit to sophiajt/rust that referenced this issue Aug 17, 2016
sophiajt pushed a commit to sophiajt/rust that referenced this issue Aug 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-diagnostics Area: Messages for errors, warnings, and lints E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.
Projects
None yet
Development

No branches or pull requests

2 participants