Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E0325 needs to be updated to new format #35329

Closed
sophiajt opened this issue Aug 4, 2016 · 1 comment
Closed

E0325 needs to be updated to new format #35329

sophiajt opened this issue Aug 4, 2016 · 1 comment
Labels
A-diagnostics Area: Messages for errors, warnings, and lints E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.

Comments

@sophiajt
Copy link
Contributor

sophiajt commented Aug 4, 2016

From: src/test/compile-fail/impl-wrong-item-for-trait.rs

Error E0324 needs a span_label, updated title, and a note, updating it from:

error[E0325]: item `bar` is an associated type, which doesn't match its trait `<FooTypeForMethod as Foo>`
  --> src/test/compile-fail/impl-wrong-item-for-trait.rs:40:5
   |
40 |     type bar = u64;
   |     ^^^^^^^^^^^^^^^

To:

error[E0325]: item `bar` is an associated type, which doesn't match its trait 
  --> src/test/compile-fail/impl-wrong-item-for-trait.rs:40:5
   |
40 |     type bar = u64;
   |     ^^^^^^^^^^^^^^^ does not match trait
   |
   = note: matching trait `<FooTypeForMethod as Foo>`

Bonus: show the original part of the trait that conflicts

error[E0325]: item `bar` is an associated type, which doesn't match its trait 
  --> src/test/compile-fail/impl-wrong-item-for-trait.rs:40:5
   |
14 |    fn bar(&self);
   |    -------------- original trait requirement
...
40 |     type bar = u64;
   |     ^^^^^^^^^^^^^^^ does not match trait
   |
   = note: matching trait `<FooTypeForMethod as Foo>`

Note: likely related to #35327 and #35325

@sophiajt sophiajt added E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. A-diagnostics Area: Messages for errors, warnings, and lints E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. labels Aug 4, 2016
sophiajt pushed a commit to sophiajt/rust that referenced this issue Aug 5, 2016
eddyb added a commit to eddyb/rust that referenced this issue Aug 6, 2016
@KiChjang
Copy link
Member

KiChjang commented Aug 8, 2016

Should be fixed by #35372.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-diagnostics Area: Messages for errors, warnings, and lints E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.
Projects
None yet
Development

No branches or pull requests

2 participants