Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E0067 needs to be updated to new format #35502

Closed
sophiajt opened this issue Aug 8, 2016 · 1 comment
Closed

E0067 needs to be updated to new format #35502

sophiajt opened this issue Aug 8, 2016 · 1 comment
Labels
A-diagnostics Area: Messages for errors, warnings, and lints E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.

Comments

@sophiajt
Copy link
Contributor

sophiajt commented Aug 8, 2016

From: src/test/compile-fail/E0067.rs

Error E0067 needs a span_label, updating it from:

error[E0067]: invalid left-hand side expression
  --> src/test/compile-fail/E0067.rs:14:5
   |
14 |     LinkedList::new() += 1; //~ ERROR E0368
   |     ^^^^^^^^^^^^^^^^^

To:

error[E0067]: invalid left-hand side expression
  --> src/test/compile-fail/E0067.rs:14:5
   |
14 |     LinkedList::new() += 1; //~ ERROR E0368
   |     ^^^^^^^^^^^^^^^^^ invalid expression for left-hand side
@sophiajt sophiajt added E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. A-diagnostics Area: Messages for errors, warnings, and lints E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. labels Aug 8, 2016
@clementmiao
Copy link
Contributor

I would like to take this issue. First time compiler hacker :)

sophiajt pushed a commit to sophiajt/rust that referenced this issue Aug 13, 2016
… r=jonathandturner

changed E0067 to new error format

Updated E0067 to new error format.
Part of rust-lang#35233
Fixes rust-lang#35502

Passes all the tests when running:
`python src/bootstrap/bootstrap.py --step check-cfail --stage 1`

**This seems strange, given that the format for E0067 has been changed.**
It feels like it should fail some unit tests maybe?

Let me know if I'm mistaken. Otherwise I can create a unit test for it.

Thanks for letting me help!

r? @jonathandturner
eddyb added a commit to eddyb/rust that referenced this issue Aug 14, 2016
… r=jonathandturner

changed E0067 to new error format

Updated E0067 to new error format.
Part of rust-lang#35233
Fixes rust-lang#35502

Passes all the tests when running:
`python src/bootstrap/bootstrap.py --step check-cfail --stage 1`

**This seems strange, given that the format for E0067 has been changed.**
It feels like it should fail some unit tests maybe?

Let me know if I'm mistaken. Otherwise I can create a unit test for it.

Thanks for letting me help!

r? @jonathandturner
eddyb added a commit to eddyb/rust that referenced this issue Aug 14, 2016
… r=jonathandturner

changed E0067 to new error format

Updated E0067 to new error format.
Part of rust-lang#35233
Fixes rust-lang#35502

Passes all the tests when running:
`python src/bootstrap/bootstrap.py --step check-cfail --stage 1`

**This seems strange, given that the format for E0067 has been changed.**
It feels like it should fail some unit tests maybe?

Let me know if I'm mistaken. Otherwise I can create a unit test for it.

Thanks for letting me help!

r? @jonathandturner
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-diagnostics Area: Messages for errors, warnings, and lints E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.
Projects
None yet
Development

No branches or pull requests

2 participants