Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E0004 bonus update: spans can't cross nodes #35529

Closed
sophiajt opened this issue Aug 8, 2016 · 4 comments
Closed

E0004 bonus update: spans can't cross nodes #35529

sophiajt opened this issue Aug 8, 2016 · 4 comments

Comments

@sophiajt
Copy link
Contributor

sophiajt commented Aug 8, 2016

From #35485

After talking with @arielb1 (and seeing @nrc's comments) - let's actually change the span to be one we can do safely:

From:

match x {
^^^^^^^ pattern `HastaLaVistaBaby` not covered

To:

match x {
      ^ pattern `HastaLaVistaBaby` not covered

CC: @KiChjang

@KiChjang
Copy link
Member

KiChjang commented Aug 8, 2016

Okay, this should be a simple fix, I'm taking it.

@arielb1
Copy link
Contributor

arielb1 commented Aug 8, 2016

I have a mega-pr #35308 that includes it.

@arielb1
Copy link
Contributor

arielb1 commented Aug 8, 2016

Still, I find spanning the scrutinee is a bit odd. But spanning the whole match isn't so pretty, so...

@KiChjang
Copy link
Member

KiChjang commented Aug 8, 2016

Commented on your PR.

steveklabnik added a commit to steveklabnik/rust that referenced this issue Aug 10, 2016
sophiajt pushed a commit to sophiajt/rust that referenced this issue Aug 10, 2016
…ndturner

Do not span across nodes for E0004

Part of rust-lang#35233.
Fixes rust-lang#35529.

r? @arielb1
sophiajt pushed a commit to sophiajt/rust that referenced this issue Aug 11, 2016
…ndturner

Do not span across nodes for E0004

Part of rust-lang#35233.
Fixes rust-lang#35529.

r? @arielb1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants