Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

run-pass/fds-are-cloexec fails with “No such file or directory” #35753

Closed
nagisa opened this issue Aug 17, 2016 · 1 comment
Closed

run-pass/fds-are-cloexec fails with “No such file or directory” #35753

nagisa opened this issue Aug 17, 2016 · 1 comment

Comments

@nagisa
Copy link
Member

nagisa commented Aug 17, 2016

Under rustbuild no Makefile needs to exist, and this test tries to open that file. The test should be changed to open something else, preferably not a file on filesystem.
@durka
Copy link
Contributor

durka commented Aug 21, 2016

How about opening the test source file itself?

durka pushed a commit to durka/rust that referenced this issue Aug 21, 2016
modify fds-are-cloexec test to open a file that exists
b40754f 
Fixes rust-lang#35753.
@durka durka mentioned this issue Aug 21, 2016
Merged
eddyb added a commit to eddyb/rust that referenced this issue Aug 23, 2016
@eddyb
Rollup merge of rust-lang#35885 - durka:gh35753, r=nagisa
7340b76 
modify fds-are-cloexec test to open a file that exists

Fixes rust-lang#35753.

Is it a valid assumption that the current directory is always the root of the repo when the tests are run?

r? @nagisa
eddyb added a commit to eddyb/rust that referenced this issue Aug 23, 2016
@eddyb
Rollup merge of rust-lang#35885 - durka:gh35753, r=nagisa
ddbc9c4 
modify fds-are-cloexec test to open a file that exists

Fixes rust-lang#35753.

Is it a valid assumption that the current directory is always the root of the repo when the tests are run?

r? @nagisa
Manishearth added a commit to Manishearth/rust that referenced this issue Aug 25, 2016
@Manishearth
Rollup merge of rust-lang#35885 - durka:gh35753, r=nagisa
7fe8d6f 
modify fds-are-cloexec test to open a file that exists

Fixes rust-lang#35753.

Is it a valid assumption that the current directory is always the root of the repo when the tests are run?

r? @nagisa
bors added a commit that referenced this issue Aug 25, 2016
@bors
Auto merge of #35885 - durka:gh35753, r=arielb1
e07dd59 
modify fds-are-cloexec test to open a file that exists

Fixes #35753.

Is it a valid assumption that the current directory is always the root of the repo when the tests are run?

r? @nagisa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@durka @nagisa