Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E0446 needs to be updated to new format #35923

Closed
sophiajt opened this issue Aug 23, 2016 · 2 comments
Closed

E0446 needs to be updated to new format #35923

sophiajt opened this issue Aug 23, 2016 · 2 comments
Labels
A-diagnostics Area: Messages for errors, warnings, and lints E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

Comments

@sophiajt
Copy link
Contributor

From: src/test/compile-fail/E0446.rs

E0446 needs a span_label, updating it from:

error[E0446]: private type in public interface
  --> src/test/compile-fail/E0446.rs:14:21
   |
14 |     pub fn bar() -> Bar { //~ ERROR E0446
   |                     ^^^

To:

error[E0446]: private type in public interface
  --> src/test/compile-fail/E0446.rs:14:21
   |
14 |     pub fn bar() -> Bar { //~ ERROR E0446
   |                     ^^^ private type can't be public
@bstrie bstrie added the A-diagnostics Area: Messages for errors, warnings, and lints label Aug 24, 2016
@brson brson added the E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. label Aug 26, 2016
@bstrie
Copy link
Contributor

bstrie commented Sep 25, 2016

Freeing this one up as part of the final push for #35233.

@bstrie
Copy link
Contributor

bstrie commented Sep 25, 2016

@Coder206 looks to have an in-progress PR to address this issue, you may want to base your work off of that one.

bors added a commit that referenced this issue Sep 27, 2016
Update E0425, E0446, E0449

This addresses #35343, #35923, and #35924.  Part of #35233

Specifically, this adds labels to these error messages following the suggestions in the attached bugs.

r? @nrc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-diagnostics Area: Messages for errors, warnings, and lints E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Development

No branches or pull requests

3 participants