Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Access to "rustc_plugin::Registry" for CompilerControllers #36064

Closed
leeopop opened this issue Aug 28, 2016 · 0 comments · Fixed by #36240
Closed

Access to "rustc_plugin::Registry" for CompilerControllers #36064

leeopop opened this issue Aug 28, 2016 · 0 comments · Fixed by #36240

Comments

@leeopop
Copy link
Contributor

leeopop commented Aug 28, 2016

Currently, Registry structure is allocated and used in the rustc_driver (

rust/src/librustc_driver/driver.rs

Line 590 in 1bf5fa3

let mut registry = Registry::new(sess, &krate);
).
It is not accessible by the CompilerController.
The CompilerController can only access the read-only version of CompileState.session.plugin_attributes.
One suggestion is to manage the Registry structure inside the CompilerState structure.

I'll prepare a pull request soon to fix this issue.

@jseyfried @sanxiyn
@leeopop leeopop mentioned this issue Sep 3, 2016
Merged
bors added a commit that referenced this issue Sep 5, 2016
@bors
Auto merge of #36240 - leeopop:master, r=jseyfried
86995dc 
Allow CompilerControllers to access rustc_plugin::registry::Registry

fixes #36064

I chose to put ructc_plugin::registry::Registry structure
into CompilerState structure, instead of Session structure.
This will preserve dependencies among librustc, libructc_driver, and libructc_plugin.

@jseyfried @sanxiyn
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow CompilerControllers to access rustc_plugin::registry::Registry
1 participant
@leeopop