debuginfo-gdb tests can't handle new gdb that supports rust #36323

infinity0 · 2016-09-07T15:47:53Z

Lots of error: line not found in debugger output e.g. see buildlog for 1.13.0~~nightly.20160904, shorter snippet of one failure: https://paste.debian.net/812883/

test result: FAILED. 37 passed; 65 failed; 3 ignored; 0 measured

The text was updated successfully, but these errors were encountered:

michaelwoerister · 2016-09-08T13:33:19Z

@brson @alexcrichton We need test infrastructure that uses a Rust-enabled version of GDB.

cc @tromey @Manishearth

Manishearth · 2016-09-08T14:09:30Z

set language rust might be necessary in those tests?

alexcrichton · 2016-10-05T00:11:23Z

Discussed during tools triage today, conclusions were:

Ideally tests would support all versions of GDB, perhaps even including a gdb/lldb style split of assertions and commands for newer versions of GDB
We should have bots testing both versions of GDB
- This may involve two bots with two versions of GDB
- It may also involve one bot testing two versions of GDB

nagisa · 2016-11-03T11:09:32Z

This is an example of a failure, which also makes it quite obvious why the tests fail:

error: line not found in debugger output: $4 = {a = 3, b = 4, c = 5, d = 6, e = 7, f = 8, g = 9, h = 10}
<snip>
$4 = function_arg_initialization::BigStruct {a: 3, b: 4, c: 5, d: 6, e: 7, f: 8, g: 9, h: 10}

This is a very nasty failure case because I haven’t seen a successful run of tests on arch for months now.

TimNN · 2016-11-03T11:15:52Z

I've got a PR ready, which fixes all those tests (for GDB trunk), #37410.

@alexcrichton

Support GDB with native rust support This PR aims at making the debuginfo tests pass with the newer GDB versions which have native rust support (RGDB) To that end debuginfo tests now support three GDB prefixes: - `gdb` applicable to both GDB varieties - `gdbg` (**G**eneric) only applicable to the old GDB - `gdbr` (**R**ust) only applicable to the new RGDB Whether the GDB has rust support is detected based on it's version: GDB >= 7.11.10 is considered to have rust support. --- **Test updates** All tests have been updated to the new GDB version. Note that some tests currently require the GDB trunk1. --- **How to move forward with this PR:** I propose the following steps for moving forward with this PR: - [x] Validate the general approach of this PR (the `gdb-`, `gdbg-` and `gdbr-` split) - [x] Validate the approach taken for updating the debuginfo tests (I've checked this since there's (almost) no `set language c` left, which was my main concern) - [x] Determine how to distinguish between the new and old GDB (and implement that) - [ ] Add one or more non-gating build bots with the new GDB (blocked on the previous item, can happen after this PR has been merged) - [ ] If the new bots pass the tests, gate on them - [x] \(Maybe) update the remaining tests to run without `set syntax c` (in a separate PR) - [ ] \(Maybe) add tests specifically for the new GDB (in a separate PR / open an issue about this) I'm not completely sure about the build bot related steps (cc @alexcrichton), the current approach was suggested to prevent any downtime / broken build time between a new GDB gating builder being added and this PR being merged. --- **Suboptimal RGDB Output** I've found several places where the output of RGDB is not ideal. They are tagged with `// FIXME`, here is an overview: - [x] Trait references are not syntactically correct: `type_names::&Trait2<...>` (**WontFix**: the issue is minor and from @Manishearth below: "to properly address the trait issue we should wait for trait object support") - [x] Univariant enums are printed as `<error reading variable>` (**Fixed** in GDB trunk1) - [x] Unions are printed as `<error reading variable>` (**Fixed** in GDB trunk1) - [x] "Nil Enums" (`enum Foo {}`) are printed as `<error reading variable>` (**WontFix**: the are not supposed to exist) - [x] I have found no alternative for `sizeof(var)` in rust mode, so had to resort to `set language c` (**Fixed** in GDB trunk1) - [x] I have found not way of interpreting a value as a specific enum variant, so had to resort to `set language c` (**Fixed** in GDB trunk1) - [x] Before the initial `run` command, gdb does not realise it should be in rust mode (thus, if one want's to print statics before the run one has to explicitly `set language rust`) (maybe this is intended / expected behaviour, if so, someone please tell me ;) (**"Expected"** / current behaviour of GDB: picks up jemalloc, see rust-lang#37410 (comment)) 1: Or rather in @Manishearth's trunk, waiting to be merged upstream. --- cc @alexcrichton, @michaelwoerister, rust-lang#36323

@alexcrichton

Support GDB with native rust support This PR aims at making the debuginfo tests pass with the newer GDB versions which have native rust support (RGDB) To that end debuginfo tests now support three GDB prefixes: - `gdb` applicable to both GDB varieties - `gdbg` (**G**eneric) only applicable to the old GDB - `gdbr` (**R**ust) only applicable to the new RGDB Whether the GDB has rust support is detected based on it's version: GDB >= 7.11.10 is considered to have rust support. --- **Test updates** All tests have been updated to the new GDB version. Note that some tests currently require the GDB trunk1. --- **How to move forward with this PR:** I propose the following steps for moving forward with this PR: - [x] Validate the general approach of this PR (the `gdb-`, `gdbg-` and `gdbr-` split) - [x] Validate the approach taken for updating the debuginfo tests (I've checked this since there's (almost) no `set language c` left, which was my main concern) - [x] Determine how to distinguish between the new and old GDB (and implement that) - [ ] Add one or more non-gating build bots with the new GDB (blocked on the previous item, can happen after this PR has been merged) - [ ] If the new bots pass the tests, gate on them - [x] \(Maybe) update the remaining tests to run without `set syntax c` (in a separate PR) - [ ] \(Maybe) add tests specifically for the new GDB (in a separate PR / open an issue about this) I'm not completely sure about the build bot related steps (cc @alexcrichton), the current approach was suggested to prevent any downtime / broken build time between a new GDB gating builder being added and this PR being merged. --- **Suboptimal RGDB Output** I've found several places where the output of RGDB is not ideal. They are tagged with `// FIXME`, here is an overview: - [x] Trait references are not syntactically correct: `type_names::&Trait2<...>` (**WontFix**: the issue is minor and from @Manishearth below: "to properly address the trait issue we should wait for trait object support") - [x] Univariant enums are printed as `<error reading variable>` (**Fixed** in GDB trunk1) - [x] Unions are printed as `<error reading variable>` (**Fixed** in GDB trunk1) - [x] "Nil Enums" (`enum Foo {}`) are printed as `<error reading variable>` (**WontFix**: the are not supposed to exist) - [x] I have found no alternative for `sizeof(var)` in rust mode, so had to resort to `set language c` (**Fixed** in GDB trunk1) - [x] I have found not way of interpreting a value as a specific enum variant, so had to resort to `set language c` (**Fixed** in GDB trunk1) - [x] Before the initial `run` command, gdb does not realise it should be in rust mode (thus, if one want's to print statics before the run one has to explicitly `set language rust`) (maybe this is intended / expected behaviour, if so, someone please tell me ;) (**"Expected"** / current behaviour of GDB: picks up jemalloc, see rust-lang#37410 (comment)) 1: Or rather in @Manishearth's trunk, waiting to be merged upstream. --- cc @alexcrichton, @michaelwoerister, rust-lang#36323

infinity0 · 2016-12-24T02:00:03Z

#37410 was closed, does that mean this is now fixed? It doesn't seem to be in 1.14.0, will it be in 1.15.0?

infinity0 · 2017-02-28T10:16:28Z

Ping! Can this be closed? A fix was apparently merged in #37597

michaelwoerister · 2017-02-28T11:19:58Z

Yes, I think this can be considered fixed.

Aatch added A-debuginfo Area: Debugging information in compiled programs (DWARF, PDB, etc.) A-amusing labels Sep 8, 2016

michaelwoerister added I-nominated labels Sep 8, 2016

alexcrichton removed the I-nominated label Oct 5, 2016

vielmetti mentioned this issue Oct 16, 2016

rust build on ARMv8 fails in test macro-stepping.rs, other debuginfo-gdb tests. #37225

Open

TimNN mentioned this issue Oct 25, 2016

Support GDB with native rust support #37410

Closed

14 tasks

michaelwoerister closed this as completed Feb 28, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

debuginfo-gdb tests can't handle new gdb that supports rust #36323

debuginfo-gdb tests can't handle new gdb that supports rust #36323

infinity0 commented Sep 7, 2016

michaelwoerister commented Sep 8, 2016

Manishearth commented Sep 8, 2016

alexcrichton commented Oct 5, 2016

nagisa commented Nov 3, 2016

TimNN commented Nov 3, 2016 •

edited

Loading

infinity0 commented Dec 24, 2016

infinity0 commented Feb 28, 2017

michaelwoerister commented Feb 28, 2017

debuginfo-gdb tests can't handle new gdb that supports rust #36323

debuginfo-gdb tests can't handle new gdb that supports rust #36323

Comments

infinity0 commented Sep 7, 2016

michaelwoerister commented Sep 8, 2016

Manishearth commented Sep 8, 2016

alexcrichton commented Oct 5, 2016

nagisa commented Nov 3, 2016

TimNN commented Nov 3, 2016 • edited Loading

infinity0 commented Dec 24, 2016

infinity0 commented Feb 28, 2017

michaelwoerister commented Feb 28, 2017

TimNN commented Nov 3, 2016 •

edited

Loading