-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Assert by level #3647
Comments
I don't think this is necessarily backwards incompatible. Given that assertions are now macros, we have a lot of flexibility to beef up the syntax in backwards-compatible ways. Nominating for some other milestone. |
note that logging is no longer parameterized by level - we have separate macros for each |
accepted for production ready |
Assigning P-low. |
I think this is too out-of-date so I've opened #12049. I think we only need to distinguish between upholding invariants and sanity checks. |
Fix futex with large timeout ICE Fixes rust-lang#3647. This PR changed the type of ``nanoseconds`` from ``u64`` to ``u128``. In ``duration_since``, nanoseconds is manually converted to second by dividing it with 1e9. But overflow is still possible.
Given the current (and potentially permanent) absence of typestate, enabling and disabling assertions by severity is a more reasonable requirement. Some assertions make more sense when in testing than in production. We should support (when we switch assertions to macros / library calls) passing a "level" parameter the same way the logging system can be parameterized by level.
The text was updated successfully, but these errors were encountered: