Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Module level attributes are being parsed before plugins are registered #36617

Closed
draivin opened this issue Sep 21, 2016 · 1 comment
Closed

Module level attributes are being parsed before plugins are registered #36617

draivin opened this issue Sep 21, 2016 · 1 comment

Comments

@draivin
Copy link

draivin commented Sep 21, 2016

Previously I was using a plugin to register a MultiModifier, and the plugin users would use a #![modifier] attribute in the entry module of their programs, so the plugin could rewrite anything inside the module.

But on the latest nightly, this results in a compilation error:

error: The attribute `modifier` is currently unknown to the compiler and may have meaning added to it in the future (see issue #29642)

This leads me to believe that module level attributes are now being parsed before the plugins finish registering.

Tagging @jseyfried.
@jseyfried jseyfried mentioned this issue Sep 21, 2016
Merged
@jseyfried
Copy link
Contributor

jseyfried commented Sep 21, 2016 •
edited
Loading

Fixed in #36618 (this was caused by #36214, unintentionally).

bors added a commit that referenced this issue Sep 22, 2016
@bors
Auto merge of #36618 - jseyfried:crate_root_attr_invoc, r=nrc
a09cb57 
macros: allow attribute invocations at the crate root

Fixes #36617.
r? @nrc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@draivin @jseyfried