Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AssociatedItem metadata gets entangled with item contents across crates #37720

Closed
nikomatsakis opened this issue Nov 11, 2016 · 0 comments
Closed

AssociatedItem metadata gets entangled with item contents across crates #37720

nikomatsakis opened this issue Nov 11, 2016 · 0 comments
Labels
A-incr-comp Area: Incremental compilation T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Milestone
Incremental compi...

Comments

@nikomatsakis
Copy link
Contributor

Within a crate, changes to the body of an impl item (with def-id X) are not considered to affect AssociatedItem(X) (because computing AssociatedItem(X) only reads from the impl). However, across crates, the data is stored with the item X along with things that are dependent on the body, and hence the results get entangled.

At least I think this is the cause. =)
@nikomatsakis nikomatsakis added the A-incr-comp Area: Incremental compilation label Nov 11, 2016
@nikomatsakis nikomatsakis added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Nov 11, 2016
@nikomatsakis nikomatsakis mentioned this issue Nov 12, 2016
Merged
nikomatsakis added a commit to nikomatsakis/rust that referenced this issue Nov 21, 2016
@nikomatsakis
restructure CollectItem dep-node to separate fn sigs from bodies
47d5ca0 
Setup two tasks, one of which only processes the signatures, in order to
isolate the typeck entries for signatures from those for bodies.

Fixes rust-lang#36078
Fixes rust-lang#37720
@bors bors closed this as completed in 688946d Nov 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-incr-comp Area: Incremental compilation T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
Incremental compilation across crates
Development

No branches or pull requests
1 participant
@nikomatsakis