New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracking issue for ptr::{read,write}_unaligned #37955

Closed

alexcrichton opened this issue Nov 23, 2016 · 12 comments

Labels

B-unstable final-comment-period T-libs-api

Member

alexcrichton commented Nov 23, 2016

Tracking issue for rust-lang/rfcs#1725

alexcrichton added B-RFC-approved T-libs-api labels

alexcrichton mentioned this issue

Add ptr::{read,write}_unaligned rust-lang/rfcs#1725

Merged

sfackler added B-unstable and removed B-RFC-approved labels

sfackler added B-RFC-approved and removed B-unstable labels

sfackler mentioned this issue

Implement RFC #1725 (read_unaligned, write_unaligned) #38309

Merged

sfackler added a commit to sfackler/rust that referenced this issue


          Implement RFC rust-lang#1725

75fe727

cc rust-lang#37955

bors added a commit that referenced this issue


          Auto merge of #38309 - sfackler:rfc-1725, r=alexcrichton

0d1b9f4

Implement RFC #1725 (read_unaligned, write_unaligned)

cc #37955

r? @alexcrichton

Contributor

chriskrycho commented Dec 30, 2016

Status check: it looks like this is implemented, behind a feature flag, and not-yet-documented?

Member

whitequark commented Feb 8, 2017

This has documentation now. What's the requirement for stabilization?

alexcrichton added B-unstable and removed B-RFC-approved labels

Member Author

alexcrichton commented Feb 8, 2017

Ah looks like this wasn't tagged B-unstable by accident which then fell under our radar. In that case...

@rfcbot fcp merge

rfcbot commented Feb 8, 2017 •

edited by brson

Loading

Team member @alexcrichton has proposed to merge this. The next step is review by the rest of the tagged teams:

No concerns currently listed.

Once these reviewers reach consensus, this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

Contributor

niconii commented Feb 11, 2017

The problem with ptr::write's docs mentioned in #39733 is true of ptr::write_unaligned's docs as well.

rfcbot commented Feb 13, 2017

🔔 This is now entering its final comment period, as per the review above. 🔔

4 similar comments

rfcbot commented Feb 13, 2017

🔔 This is now entering its final comment period, as per the review above. 🔔

rfcbot commented Feb 13, 2017

🔔 This is now entering its final comment period, as per the review above. 🔔

rfcbot commented Feb 13, 2017

🔔 This is now entering its final comment period, as per the review above. 🔔

rfcbot commented Feb 13, 2017

🔔 This is now entering its final comment period, as per the review above. 🔔

rfcbot added the final-comment-period label

Member

whitequark commented Feb 13, 2017

@rfcbot calm down please

rfcbot commented Feb 23, 2017

The final comment period is now complete.

frewsxcv pushed a commit to frewsxcv/rust that referenced this issue


          Stabilize ptr_unaligned feature, closes rust-lang#37955

f789955

alexcrichton pushed a commit to alexcrichton/rust that referenced this issue


          Stabilize ptr_unaligned feature, closes rust-lang#37955

ba0f045

bors closed this as completed in

d38ea8b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment