Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustbuild should permit configuring the "make" program at configure time #38429

Closed
semarie opened this issue Dec 17, 2016 · 1 comment
Closed

rustbuild should permit configuring the "make" program at configure time #38429

semarie opened this issue Dec 17, 2016 · 1 comment
Labels
T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@semarie
Copy link
Contributor

semarie commented Dec 17, 2016

On BSD system the "make" program isn't GNU-make, and the Makefile format aren't strictly compatible.

For example, src/libstd/build.rs try to invoke make to build libbacktrace. Same problem in src/bootstrap/check.rs.

The "make" program should be configurable. GNU-make is generally "gmake" on BSD.
@sanxiyn sanxiyn added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label Dec 17, 2016
@semarie
Copy link
Contributor Author

semarie commented Dec 17, 2016

I started to work on it.

@semarie semarie mentioned this issue Dec 18, 2016
Merged
4 tasks
@bors bors closed this as completed in a7d9025 Dec 21, 2016
brson pushed a commit to brson/rust that referenced this issue Jan 19, 2017
@semarie @brson
let BSD to use gmake for GNU-make
1dfb78f 
the diff extends build_helper to provide an function to return the
expected name of GNU-make on the host: "make" or "gmake".

Fixes rust-lang#38429
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sanxiyn @semarie