vendored dependendencies are incomplete in the beta and nightly tarballs #38690
Labels
P-high
High priority
regression-from-stable-to-beta
Performance or correctness regression from stable to beta.
Comments
|
Needs to be fixed for 1.15. |
brson
added
regression-from-stable-to-beta
|
Seems like the vendoring process should include a sanity check that the vendored sources hash correctly. |
|
Fixed in #38708 |
bors
added a commit
that referenced
this issue
Dec 31, 2016
Gate on distcheck on Travis This commit adds a new entry to the Travis matrix to gate on distcheck, the illustrious test process that has historically taken *8 hours* to complete and also breaks all the time on nightly. By adding it to Travis we should hope to never see nightly breakage (like #38690) because of this ever again! "But wait, surely we can't wait 8 hours for all PRs!" you might be thinking, and you are indeed correct. The distcheck added here is much more optimized for speed than the old buildbot instances for a number of reasons: * We're not building *two host compilers* beforehand. The current distcheck bot does a cross for i686 Linux and x86_64 Linux before it actually runs distcheck, building 6 compilers and LLVM twice. None of this is done in parallel as well (e.g. `-j1`). Not doing any of this work will be a huge win! * We're using sccache to compile LLVM, so it should be much faster. Distcheck on the bots didn't cache LLVM well and rebuilt it every time. All in all, this version of "distcheck" should be exactly like other matrix entries that run tests except that it's a *little* slower to start as it has to create the source tarball then rebuild the build system in the distcheck dir. Overall this should be well under the 2 hours that Android is currently taking anyway. Closes #38691
|
Things move fast around here. Awesome thanks!
…On Jan 1, 2017 1:27 AM, "bors" ***@***.***> wrote:
Closed #38690 <#38690> via d0881ea
<d0881ea>
.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#38690 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAtRrxHQ4gsbSj8XnoWveBIZp8e5j445ks5rNvL6gaJpZM4LX2VK>
.
|
nikomatsakis
pushed a commit
to nikomatsakis/rust
that referenced
this issue
Jan 6, 2017
The source tarball creation step would attempt to skip a number of files that we want to ignore ourselves, but once we've hit the vendor directory we don't want to skip anything so be sure to vendor everything inside that directory. Closes rust-lang#38690
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The process of creating the tarballs doesn't include .gitignore files from src/vendor. This results in a missmatched hash failure when building with vendoring enabled. Hoping to switch to rustbuild with the next rust release!
FYI: I'd be happy with the vendoring happening during the create tarball process, having enormous vendoring commits in the git history is ugly...
The text was updated successfully, but these errors were encountered: