Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove is_like_X flags from target specs #38732

Closed
brson opened this issue Dec 31, 2016 · 3 comments
Closed

Remove is_like_X flags from target specs #38732

brson opened this issue Dec 31, 2016 · 3 comments
Labels
A-target-specs Area: compile-target specifications C-cleanup Category: PRs that clean code up or issues documenting cleanup.

Comments

@brson
Copy link
Contributor

brson commented Dec 31, 2016

Today target specs have is_like_openbsd, is_like_osx, is_like_solaris, is_like_windows, is_like_android, is_like_msvc fields. These all seem to amount to querying target_os. They could instead be methods on target spec.

cc #36900 (comment)

@nagisa
Copy link
Member

nagisa commented Dec 31, 2016

When I was writing the RFC on Target Bundles, it didn’t seem to me that target_os and is_like* are interchangeable. The RFC I linked here also has a proposal on how to adjust target spec to get rid of these is_like fields :)

@Mark-Simulacrum Mark-Simulacrum added the A-target-specs Area: compile-target specifications label Jun 23, 2017
@Mark-Simulacrum Mark-Simulacrum added the C-cleanup Category: PRs that clean code up or issues documenting cleanup. label Jul 26, 2017
@jackh726
Copy link
Member

Going to go ahead and close this, since this might not even be possible, and is old enough that nobody will probably work on this.

@petrochenkov
Copy link
Contributor

cc #98214

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-target-specs Area: compile-target specifications C-cleanup Category: PRs that clean code up or issues documenting cleanup.
Projects
None yet
Development

No branches or pull requests

5 participants