-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove is_like_X flags from target specs #38732
Labels
A-target-specs
Area: compile-target specifications
C-cleanup
Category: PRs that clean code up or issues documenting cleanup.
Comments
When I was writing the RFC on Target Bundles, it didn’t seem to me that |
Mark-Simulacrum
added
the
C-cleanup
Category: PRs that clean code up or issues documenting cleanup.
label
Jul 26, 2017
Going to go ahead and close this, since this might not even be possible, and is old enough that nobody will probably work on this. |
cc #98214 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-target-specs
Area: compile-target specifications
C-cleanup
Category: PRs that clean code up or issues documenting cleanup.
Today target specs have
is_like_openbsd
,is_like_osx
,is_like_solaris
,is_like_windows
,is_like_android
,is_like_msvc
fields. These all seem to amount to queryingtarget_os
. They could instead be methods on target spec.cc #36900 (comment)
The text was updated successfully, but these errors were encountered: