-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get test suite working with wasm #38800
Comments
This is still a critical wasm bug, and not a difficult one to fix. Run the test suite against the wasm target to see how it's currently broken. Most should simply be failing to load the wasm correctly. It should be possible to get verbose output from the test suite, then take that output and run the node.js test command by hand to figure out the correct invocation; then modify compiletest to do it correctly. |
I'm going to have a look at this but I make no promises so someone else who wants to take it should do so. |
OK my strategy is
I'm away for a few days so if this looks good I'll probably do it on wednesday :) |
Oh and I also had to pass "-s BINARYEN_METHOD='native-wasm,interpret-binary'" as it defaulted to just |
…xcrichton Make compiletest set cwd before running js tests Proposed fix for #38800. Not all tests pass yet - I will mention failures here once the test suite has finished.
I believe this has largely be done and can be verified with the containers in-tree, so closing. |
Last I looked compiletest could not deal with wasm as outputted today by rustc because the binaryen interpreter expects the wasm file to be located in a specific relative path that compiletest does not set up correctly.
I recall the fix being a matter of refactoring compiletest to pass certain paths down to the process spawning node.
The text was updated successfully, but these errors were encountered: