Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad documentation for --emit-llvm and --save-temps compiler flags #3945

Closed
catamorphism opened this issue Nov 9, 2012 · 7 comments
Closed
Labels
A-driver Area: rustc_driver that ties everything together into the `rustc` compiler P-medium Medium priority
Milestone

Comments

@catamorphism
Copy link
Contributor

Today I learned:

  • --emit-llvm silently does nothing if you're compiling to an executable, and requires that you provide a -o filename that ends in .bc. Perhaps there should be errors instead.
  • --save-temps and --emit-llvm only do anything if they come before the crate file name.

These things should probably be documented. I'm not sure where such documentation belongs (seems a bit verbose for the command-line usage notes).

@catamorphism
Copy link
Contributor Author

Not critical for 0.6, de-milestoning.

@metajack
Copy link
Contributor

Nominating for well covered.

@graydon
Copy link
Contributor

graydon commented May 16, 2013

accepted for production-ready milestone

@brson
Copy link
Contributor

brson commented Jul 29, 2013

cc #7791

@pnkfelix
Copy link
Member

probably subsumed by #7791. But tagging 1.0 to ensure it gets fixed one way or another. P-high.

@lucab
Copy link
Contributor

lucab commented Feb 20, 2014

I believe this has been closed in the above bug/PR:

$ rustc -v
 rustc 0.10-pre (0cc8ba0 2014-02-19 21:56:51 -0800)
 host: x86_64-unknown-linux-gnu
$ rustc --emit=ir mainpage.rs
$ ls
 mainpage.ll  mainpage.rs
$ rustc -C save-temps mainpage.rs 
$ ls
 mainpage  mainpage.bc  mainpage.metadata.o  mainpage.no-opt.bc  mainpage.o  mainpage.rs

Can anybody close it?

@alexcrichton
Copy link
Member

Indeed, closed by 6e7968b (we even have dox in the manpage!)

RalfJung pushed a commit to RalfJung/rust that referenced this issue Oct 15, 2024
avoid pthread_attr_t in tests

We don't support `pthread_attr_init` so the code here is actually technically wrong (passing attributes to `pthread_create` that were not initialized properly). It's also unnecessary, we can just pass a null pointer for the attributes to indicate "default attributes please".
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-driver Area: rustc_driver that ties everything together into the `rustc` compiler P-medium Medium priority
Projects
None yet
Development

No branches or pull requests

7 participants