Skip to content

Encapsulate used-trait-imports set from typeck into per-fn-node tables #39495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nikomatsakis opened this issue Feb 3, 2017 · 0 comments
Closed

Encapsulate used-trait-imports set from typeck into per-fn-node tables #39495

nikomatsakis opened this issue Feb 3, 2017 · 0 comments
Labels
A-incr-comp Area: Incremental compilation T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Milestone
Incremental compi...

Comments

@nikomatsakis
Copy link
Contributor

nikomatsakis commented Feb 3, 2017 •
edited
Loading

Background: See the general plan for skipping typeck.

Currently we write to a table in the tcx that is not tracked. We need to have each fn's results preserved somewhere so they can be reloaded from incr. state and recombined without re-running typeck.

Pending PR: #39434
@nikomatsakis nikomatsakis added A-incr-comp Area: Incremental compilation T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 3, 2017
This was referenced Feb 3, 2017
Merged
Closed
bors added a commit that referenced this issue Feb 4, 2017
@bors
Auto merge of #39434 - nikomatsakis:incr-comp-skip-typeck-2, r=eddyb
e4eea73 
Miscellaneous refactors around how lints and typeck interact

This is preparation for making incr. comp. skip typeck. The main gist of is trying to rationalize the outputs from typeck that are not part of tables:

- one bit of output is the `used_trait_imports` set, which becomes something we track for dependencies
- the other big of output are various lints; we used to store these into a table on sess, but this work stores them into the`TypeckTables`, and then makes the lint pass consult that
    - I think it probably makes sense to handle errors similarly, eventually, but that's not necessary now

r? @eddyb

Fixes #39495
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-incr-comp Area: Incremental compilation T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
Incremental compilation in typechecking
Development

No branches or pull requests
1 participant
@nikomatsakis