Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[rustbuild] --build flag should have priority over value specified in config.toml #39673

Closed
nagisa opened this issue Feb 9, 2017 · 0 comments
Closed

[rustbuild] --build flag should have priority over value specified in config.toml #39673

nagisa opened this issue Feb 9, 2017 · 0 comments
Labels
C-feature-request Category: A feature request, i.e: not implemented / a PR. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@nagisa
Copy link
Member

nagisa commented Feb 9, 2017 

python x.py test --host=x86_64-unknown-linux-gnu --stage=2 --target=x86_64-unknown-linux-gnu --build=x86_64-unknown-linux-gnu
    Finished debug [unoptimized] target(s) in 0.0 secs
...
Building stage0 std artifacts (i686-unknown-linux-gnu -> i686-unknown-linux-gnu)

where all build was uncommented and set to i686-unknown-linux-gnu in config.toml. It seems weird that it is still building i686 when all possible flags specify x86_64. Works as expected if build is commented out as far as I can tell.
@alexcrichton alexcrichton added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label Feb 9, 2017
@Mark-Simulacrum Mark-Simulacrum added the C-feature-request Category: A feature request, i.e: not implemented / a PR. label Jul 27, 2017
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this issue Aug 10, 2017
@Mark-Simulacrum
Allow overriding build triple via flag.
302a08c 
We first check the configuration, then passed parameters (--build), then
fall back to the auto-detection that bootstrap.py does.

Fixes rust-lang#39673.
@bors bors closed this as completed in 5290c6c Aug 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-feature-request Category: A feature request, i.e: not implemented / a PR. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@alexcrichton @nagisa @Mark-Simulacrum