Skip to content

highlight-1.0.0 doesn't build on 1.16 beta #39806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
brson opened this issue Feb 14, 2017 · 9 comments
Closed

highlight-1.0.0 doesn't build on 1.16 beta #39806

brson opened this issue Feb 14, 2017 · 9 comments
Labels
regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Comments

@brson
Copy link
Contributor

brson commented Feb 14, 2017

https://github.com/neunenak/hilite ac0768130d52219a247d383285ac4adb88d8d1f0

   Compiling getopts v0.2.14
   Compiling hilite v1.0.0 (file:///mnt2/dev/hilite)
error[E0277]: the trait bound `&&[std::string::String]: std::iter::Iterator` is not satisfied
  --> src/main.rs:83:32
   |
83 |                               .args(& program_args)
   |                                ^^^^ the trait `std::iter::Iterator` is not implemented for `&&[std::string::String]`
   |
   = note: `&&[std::string::String]` is not an iterator; maybe try calling `.iter()` or a similar method
   = note: required because of the requirements on the impl of `std::iter::IntoIterator` for `&&[std::string::String]`

error: aborting due to previous error

error: Could not compile `hilite`.

To learn more, run the command again with --verbose.
rustc 1.16.0-beta.1 (5276ba72e 2017-01-31)
binary: rustc
commit-hash: 5276ba72e8fe13597200254447fce9cb3783c583
commit-date: 2017-01-31
host: x86_64-unknown-linux-gnu
release: 1.16.0-beta.1
LLVM version: 3.9

cc @neunenak

@brson brson added regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 14, 2017
@brson
Copy link
Contributor Author

brson commented Feb 14, 2017

This also affects http2hpack-0.1.3 and lsio-0.1.16 cc @lambdastackio

@malbarbo
Copy link
Contributor

This also affects rustup

@alexcrichton
Copy link
Member

"expected" breakage from #38856 I believe

@brson
Copy link
Contributor Author

brson commented Feb 14, 2017

Also read-process-memory-0.1.0 and renv-0.2.2 cc @luser @cmsd2

@luser
Copy link
Contributor

luser commented Feb 15, 2017

read-process-memory was a trivial fix to a test: luser/read-process-memory@28a887f . Thanks for the heads up!

@cmsd2
Copy link

cmsd2 commented Feb 15, 2017

fixed cmsd2/renv@23053d2

@arielb1 arielb1 added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. and removed T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 16, 2017
@arielb1
Copy link
Contributor

arielb1 commented Feb 16, 2017

This is expected inference breakage - moving to T-libs.

@luser
Copy link
Contributor

luser commented Feb 17, 2017

I published read-process-memory 0.1.1 with the fix.

@alexcrichton
Copy link
Member

Discussed during libs triage today the conclusion was that this falls under "acceptable API evolution", so we're not going to revert. If any assistance is needed though in updating crates, please let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

6 participants