Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cannot resolve std::net::Ipv4Addr: std::cmp::PartialEq in scan-rules-0.2.0, Rust 1.16 beta #39825

Closed
brson opened this issue Feb 14, 2017 · 3 comments
Labels
regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Comments

@brson
Copy link
Contributor

brson commented Feb 14, 2017

brian@ip-10-145-43-250:~/dev/rust-scan-rules⟫ git remote -v
origin  https://github.com/DanielKeep/rust-scan-rules (fetch)
origin  https://github.com/DanielKeep/rust-scan-rules (push)
brian@ip-10-145-43-250:~/dev/rust-scan-rules⟫ git log -1
commit 151b4d822c33dcb8a04d9fa55d1084c948e5b76d
Author: Daniel Keep <daniel.keep@gmail.com>
Date:   Mon Nov 7 16:27:19 2016 +1100

    chore: updated docs for release.
brian@ip-10-145-43-250:/mnt2/dev⟫ rustc +beta -Vv
rustc 1.16.0-beta.1 (5276ba72e 2017-01-31)
binary: rustc
commit-hash: 5276ba72e8fe13597200254447fce9cb3783c583
commit-date: 2017-01-31
host: x86_64-unknown-linux-gnu
release: 1.16.0-beta.1
LLVM version: 3.9
brian@ip-10-145-43-250:~/dev/rust-scan-rules⟫ cargo +beta test
   Compiling scan-rules v0.2.0 (file:///mnt2/dev/rust-scan-rules)
error[E0283]: type annotations required: cannot resolve `std::net::Ipv4Addr: std::cmp::PartialEq<_>`
   --> src/scanner/std/net.rs:225:31
    |
225 |                 Ok((v, n)) if v == $s.parse().unwrap() && n == $s.len()
    |                               ^^^^^^^^^^^^^^^^^^^^^^^^
...
244 |     check_ipv4!("0.0.0.0");
    |     ----------------------- in this macro invocation

warning: unused `#[macro_use]` import, #[warn(unused_imports)] on by default
  --> examples/runtime_scanners.rs:10:1
   |
10 | #[macro_use] extern crate scan_rules;
   | ^^^^^^^^^^^^

error: aborting due to previous error

error: Could not compile `scan-rules`.
Build failed, waiting for other jobs to finish...
error: build failed

Not on 1.15.

cc @DanielKeep

@arielb1
Copy link
Contributor

arielb1 commented Feb 16, 2017

This is caused by an impl added in 9301e2e. T-libs XIB.

@arielb1 arielb1 added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Feb 16, 2017
@alexcrichton
Copy link
Member

PR in question is #38464

@alexcrichton
Copy link
Member

Discussed during libs triage today the conclusion was that this falls under the "acceptable api evolution" category, so we're not going to revert.

@DanielKeep or @achanda if you need help updating though please just let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

3 participants