Slash (/) in diagnostic's path on Windows

[KalitaAlexey]

cargo new app

src/lib.rs: mod f;

src/f/mod.rs: f

cargo build

error: expected one of `!` or `::`, found `<eof>`
 --> src\f/mod.rs:1:1

It must be src\f \ mod.rs, but it is src\f / mod.rs

src/f/mod.rs: mod g;

src/f/g/mod.rs: g

cargo build

error: expected one of `!` or `::`, found `<eof>`
 --> src\f\g/mod.rs:1:1

[retep998]

Is some code in rustc somewhere hardcoding / instead of using std::path::MAIN_SEPARATOR (or just joining paths the normal way)?

[KalitaAlexey]

@retep998,
Probably it is.

[steveklabnik]

Seeing this myself.

[retep998]

Could it be the fault of this line? https://github.com/rust-lang/rust/blob/master/src/libsyntax/parse/parser.rs#L5148

let secondary_path_str = format!("{}/mod.rs", mod_name);

[KalitaAlexey]

I suppose we need to add some tests to check it.

[radix]

@retep998 it's not just that, since I also see it for non-mod.rs cases.

[adchilds]

Looks like the issue @radix is seeing may be caused by https://github.com/rust-lang/rust/blob/master/src/libstd/sys_common/backtrace.rs#L265

[retep998]

So now someone just needs to write a PR to fix those two spots!

[laumann]

Would https://github.com/rust-lang/rust/blob/master/src/libsyntax/parse/parser.rs#L5307 also qualify?

[retep998]

@laumann Yes.

[laumann]

@retep998 Included