Skip to content

Rewrite tests.mk in Rust #4019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
brson opened this issue Nov 22, 2012 · 9 comments
Closed

Rewrite tests.mk in Rust #4019

brson opened this issue Nov 22, 2012 · 9 comments
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc C-cleanup Category: PRs that clean code up or issues documenting cleanup.

Comments

@brson
Copy link
Contributor

brson commented Nov 22, 2012

All the Rust tests use the Rust test runner. The Makefile for the test suite is one big macro for configuring the Rust test runner. It's self contained, and needs to be rewritten for the next build system.

Integrate with @graydon's build system. It may make sense to put useful bits in std::test.

@nikomatsakis
Copy link
Contributor

Not critical for 0.6; removing milestone

@bstrie
Copy link
Contributor

bstrie commented May 13, 2013

@catamorphism , does this sound like something that's now the purview of rustpkg?

@emberian
Copy link
Member

Visiting for triage; not all the tests use the official test runner, a bunch of them use compiletest etc... I'm certainly in favor of slaughtering tests.mk but it'd probably need to be done with the rest of the codebase when it's ported to rustpkg (though it could probably be ported first, or something?)

/cc @catamorphism

@brson
Copy link
Contributor Author

brson commented Jul 20, 2013

rustpkg will not be sufficient to replace tests.mk. between compiletest and the doc tests, it does a lot

@brson
Copy link
Contributor Author

brson commented Jul 20, 2013

and compiletest and the doc tests do use the rust test runner

@metajack
Copy link
Contributor

triage bump. nothing to add.

@huonw
Copy link
Member

huonw commented Mar 2, 2014

part of #8058

@treeman
Copy link
Contributor

treeman commented Sep 16, 2014

Triage bump.

@brson
Copy link
Contributor Author

brson commented Jan 13, 2015

I don't have any particular desire to rewrite the build system in rust these days. Bootstrapping all the things doesn't really hold the same allure to me any more. When we rewrite the Rust buildsystem I'll probably be more inclined to do it in Python.

@brson brson closed this as completed Jan 13, 2015
RalfJung pushed a commit to RalfJung/rust that referenced this issue Nov 10, 2024
mati865 pushed a commit to mati865/rust that referenced this issue Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc C-cleanup Category: PRs that clean code up or issues documenting cleanup.
Projects
None yet
Development

No branches or pull requests

7 participants