Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tidy errors don't abort make -jn #4034

Closed
catamorphism opened this issue Nov 24, 2012 · 1 comment
Closed

tidy errors don't abort make -jn #4034

catamorphism opened this issue Nov 24, 2012 · 1 comment

Comments

@catamorphism
Copy link
Contributor

Write code with long lines, run make check -j12, ignore the tidy errors because everything has scrolled too far and tidy won't abort the build when running with -j, check in code with tidy errors. This has happened to me at least once.

I'm not sure if this is an inherent limitation of make, but maybe it's another reason to rewrite the build system in Rust?

@graydon
Copy link
Contributor

graydon commented Dec 4, 2012

$ make -j 20 check
cfg: shell host triple x86_64-unknown-linux-gnu
cfg: host for x86_64-unknown-linux-gnu is x86_64
cfg: unix-y environment
cfg: using gcc
cfg: no llnextgen found, omitting grammar-verification
cfg: including dist rules
cfg: including test rules
check: formatting
compile_and_link: x86_64-unknown-linux-gnu/stage0/lib/rustc/x86_64-unknown-linux-gnu/lib/libcore.so
extract: tutorial tests
extract: tutorial-ffi tests
extract: tutorial-macros tests
extract: tutorial-borrowed-ptr tests
extract: tutorial-tasks tests
extract: ref tests
/home/graydon/src/rust/src/libcore/core.rs:76: tab character
/home/graydon/src/rust/src/libcore/core.rs:76: trailing whitespace
make: *** [tidy] Error 123
make: *** Waiting for unfinished jobs....
$

Wfm in this case. Maybe run builds with make -j 20 || echo "ERROR" ? In any case, we are definitely rewriting it in rust asap (I know "asap" seems to mean "in quite a while" around here) so I'm going to close this as a dupe of #2237 / #2238.

@graydon graydon closed this as completed Dec 4, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants