-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error messages don't follow style convention of Trait<Type = T> #40641
Labels
A-diagnostics
Area: Messages for errors, warnings, and lints
C-enhancement
Category: An issue proposing an enhancement or a PR with one.
Comments
Fixing it. |
Actually that'd be nice to have an error code to starting working on (so that I can get a start point to fix others as well). |
I did it first in rustdoc. |
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this issue
Mar 22, 2017
…ype-formatting, r=frewsxcv Add whitespace around "=" in assoc items Part of rust-lang#40641. r? @rust-lang/docs Before: <img width="1440" alt="screen shot 2017-03-20 at 22 42 34" src="https://cloud.githubusercontent.com/assets/3050060/24123102/89181d8c-0dbe-11e7-897c-841497cf7001.png"> After: <img width="1440" alt="screen shot 2017-03-20 at 22 42 36" src="https://cloud.githubusercontent.com/assets/3050060/24123118/8dec176e-0dbe-11e7-9759-cabbd062a4c2.png">
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this issue
Mar 22, 2017
…ype-formatting, r=frewsxcv Add whitespace around "=" in assoc items Part of rust-lang#40641. r? @rust-lang/docs Before: <img width="1440" alt="screen shot 2017-03-20 at 22 42 34" src="https://cloud.githubusercontent.com/assets/3050060/24123102/89181d8c-0dbe-11e7-897c-841497cf7001.png"> After: <img width="1440" alt="screen shot 2017-03-20 at 22 42 36" src="https://cloud.githubusercontent.com/assets/3050060/24123118/8dec176e-0dbe-11e7-9759-cabbd062a4c2.png">
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this issue
Mar 22, 2017
…ype-formatting, r=frewsxcv Add whitespace around "=" in assoc items Part of rust-lang#40641. r? @rust-lang/docs Before: <img width="1440" alt="screen shot 2017-03-20 at 22 42 34" src="https://cloud.githubusercontent.com/assets/3050060/24123102/89181d8c-0dbe-11e7-897c-841497cf7001.png"> After: <img width="1440" alt="screen shot 2017-03-20 at 22 42 36" src="https://cloud.githubusercontent.com/assets/3050060/24123118/8dec176e-0dbe-11e7-9759-cabbd062a4c2.png">
Mark-Simulacrum
added
the
A-diagnostics
Area: Messages for errors, warnings, and lints
label
Jun 13, 2017
Mark-Simulacrum
added
the
C-enhancement
Category: An issue proposing an enhancement or a PR with one.
label
Jul 26, 2017
So I actually don't remember what specific errors this was for, but on the latest nightly:
I get:
So I'm going to close this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-diagnostics
Area: Messages for errors, warnings, and lints
C-enhancement
Category: An issue proposing an enhancement or a PR with one.
Currently, rustfmt modifies these statements to include a space around the equal sign, but error messages don't do this. I'd appreciate if this were changed to follow rustfmt because I use Fira Code which converts
=<
into a ligature for≤
, and statements like the below format awkwardly:std::ops::Index<std::ops::RangeFrom<usize>, Output=<T as strlike::StrLike>::Data>
The text was updated successfully, but these errors were encountered: