Skip to content

Incorrect FileCheck path on msvc and RelWithDbgInfo #40680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
TimNN opened this issue Mar 20, 2017 · 2 comments
Closed

Incorrect FileCheck path on msvc and RelWithDbgInfo #40680

TimNN opened this issue Mar 20, 2017 · 2 comments
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc C-bug Category: This is a bug. O-windows-msvc Toolchain: MSVC, Operating system: Windows T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@TimNN
Copy link
Contributor

TimNN commented Mar 20, 2017

When compiling for msvc and using a RelWithDbgInfo LLVM, an incorrect path to FileCheck.exe is used (hardcoded to Release/bin).

I find the exact conditions which determine the directory to use a bit confusing.

@TimNN TimNN changed the title Incorrect FileCheck path on msvc + and RelWithDbgInfo Incorrect FileCheck path on msvc and RelWithDbgInfo Mar 20, 2017
@alexcrichton alexcrichton added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label Mar 20, 2017
@alexcrichton
Copy link
Member

I also find the directory layout of an LLVM build confusing ;_;

@Mark-Simulacrum Mark-Simulacrum added O-windows-msvc Toolchain: MSVC, Operating system: Windows A-testsuite Area: The testsuite used to check the correctness of rustc labels Jun 13, 2017
@Mark-Simulacrum Mark-Simulacrum added the C-bug Category: This is a bug. label Jul 27, 2017
@Mark-Simulacrum Mark-Simulacrum added this to the impl period milestone Sep 15, 2017
@aturon aturon removed this from the impl period milestone Sep 15, 2017
@wesleywiser
Copy link
Member

Looks like this was fixed in #50961.

rust/src/bootstrap/lib.rs

Lines 803 to 815 in 256721e

let base = if !self.ninja() && self.config.build.contains("msvc") {
if self.config.llvm_optimize {
if self.config.llvm_release_debuginfo {
base.join("RelWithDebInfo")
} else {
base.join("Release")
}
} else {
base.join("Debug")
}
} else {
base
};

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc C-bug Category: This is a bug. O-windows-msvc Toolchain: MSVC, Operating system: Windows T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

No branches or pull requests

5 participants