Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AsciiExt docs are incorrect #40714

Closed
steveklabnik opened this issue Mar 21, 2017 · 5 comments
Closed

AsciiExt docs are incorrect #40714

steveklabnik opened this issue Mar 21, 2017 · 5 comments
Labels
A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-help-wanted Call for participation: Help is requested to fix this issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.

Comments

@steveklabnik
Copy link
Member

steveklabnik commented Mar 21, 2017

https://doc.rust-lang.org/stable/std/ascii/trait.AsciiExt.html

Extension methods for ASCII-subset only operations on string slices.

but at the bottom

    impl AsciiExt for str
    impl AsciiExt for [u8]
    impl AsciiExt for u8
    impl AsciiExt for char

That is, they are not just for string slices, but also for u8 slices, u8, and char.

I'm not sure what the right wording is here, exactly, maybe just drop the whole 'on string slices' bit.

I'm happy to mentor anyone who wants to tackle this issue.

@steveklabnik steveklabnik added A-docs E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-help-wanted Call for participation: Help is requested to fix this issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools labels Mar 21, 2017
@alanstoate
Copy link
Contributor

I'm interested in working on this

@steveklabnik
Copy link
Member Author

@alanstoate awesome! please let me know if you need any help at all, very happy to do so.

@alanstoate
Copy link
Contributor

@steveklabnik since all the examples on that page are using char's would it be worth updating one or two to show other types being used?

e.g

let ascii_uint = 97;         // 97 represents ascii 'a'

assert_eq!(65, ascii_uint.to_ascii_uppercase()) // 65 represents ascii 'A'

@steveklabnik
Copy link
Member Author

That'd be nice as well, yeah

@mrhota
Copy link
Contributor

mrhota commented Apr 18, 2017

@steveklabnik looks like the linked PR is merged, so maybe you can close this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-help-wanted Call for participation: Help is requested to fix this issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.
Projects
None yet
Development

No branches or pull requests

3 participants