Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rustdoc sidebar style change negatively impacts src view #40724

Closed
Cldfire opened this issue Mar 22, 2017 · 5 comments
Closed

Rustdoc sidebar style change negatively impacts src view #40724

Cldfire opened this issue Mar 22, 2017 · 5 comments
Assignees
Labels
P-medium Medium priority regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@Cldfire
Copy link
Contributor

Cldfire commented Mar 22, 2017

What it looks like on nightly docs:

top_nightly

bottom_nightly

The strange color change on the side with the new sidebar style looks kind of tacky (especially at the bottom) and was probably not intended.

Currently on stable docs:

top_stable

bottom_stable

@steveklabnik steveklabnik added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. regression-from-stable-to-beta Performance or correctness regression from stable to beta. labels Mar 22, 2017
@steveklabnik
Copy link
Member

This is also broken on beta, tagging as such.

@wesleywiser
Copy link
Member

I'm looking into this. I see three potential options:

  1. Make the sidebar white on the src pages. This would look the same as the old styling.
  2. Shrink the width of the src view so it doesn't overlap with the sidebar. The sidebar is empty on src pages though so this looks kind of weird. If the sidebar retained its items from the other doc pages, this might look nice.
  3. Make the sidebar color and the background of the code block match so there isn't slightly different shades of grey on top of each other.

I'm leaning toward option 1 for now but I think option 2 might be worth considering in the future. Thoughts?

@Cldfire
Copy link
Contributor Author

Cldfire commented Mar 23, 2017

While I am certainly not the most qualified to weigh in on this, my thoughts would be that 3 is less than desirable (having a random grey stripe on the left side looks out-of-place regardless of whether the color matches or not), 2 would unnecessarily decrease the usability of src pages by decreasing the amount of horizontal space available to the code, and 1 is likely the best option.

3 would also mean that the code block would have padding on the right side but no padding on the left.

@steveklabnik
Copy link
Member

1 seems good

@wesleywiser
Copy link
Member

Ok. Option 1 it is!

@brson brson added the P-medium Medium priority label Mar 23, 2017
wesleywiser added a commit to wesleywiser/rust that referenced this issue Mar 29, 2017
frewsxcv added a commit to frewsxcv/rust that referenced this issue Mar 31, 2017
…GuillaumeGomez

Make the rustdoc sidebar white on `src` pages

Fixes rust-lang#40724
alexcrichton pushed a commit to alexcrichton/rust that referenced this issue Apr 1, 2017
michaelwoerister pushed a commit to michaelwoerister/rust that referenced this issue Apr 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P-medium Medium priority regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

4 participants