-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rustdoc sidebar style change negatively impacts src
view
#40724
Comments
This is also broken on beta, tagging as such. |
I'm looking into this. I see three potential options:
I'm leaning toward option 1 for now but I think option 2 might be worth considering in the future. Thoughts? |
While I am certainly not the most qualified to weigh in on this, my thoughts would be that 3 is less than desirable (having a random grey stripe on the left side looks out-of-place regardless of whether the color matches or not), 2 would unnecessarily decrease the usability of 3 would also mean that the code block would have padding on the right side but no padding on the left. |
1 seems good |
Ok. Option 1 it is! |
…GuillaumeGomez Make the rustdoc sidebar white on `src` pages Fixes rust-lang#40724
What it looks like on nightly docs:
The strange color change on the side with the new sidebar style looks kind of tacky (especially at the bottom) and was probably not intended.
Currently on stable docs:
The text was updated successfully, but these errors were encountered: