Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracking issue for the addition of the compile_error! macro #40872

Closed
sfackler opened this issue Mar 28, 2017 · 10 comments
Closed

Tracking issue for the addition of the compile_error! macro #40872

sfackler opened this issue Mar 28, 2017 · 10 comments
Labels
B-RFC-approved Blocker: Approved by a merged RFC but not yet implemented. final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Comments

@sfackler
Copy link
Member

rust-lang/rfcs#1695
@sfackler sfackler added B-RFC-approved Blocker: Approved by a merged RFC but not yet implemented. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. labels Mar 28, 2017
@sfackler sfackler mentioned this issue Mar 28, 2017
Merged
@sfackler
Copy link
Member Author

cc @sgrif

@est31
Copy link
Member

est31 commented Apr 28, 2017 •
edited
Loading

On IRC, @moonheart08 has expressed desire to implement this. I've helped a little bit, can continue mentoring.

@killercup killercup mentioned this issue May 11, 2017
Merged
@jrasky jrasky mentioned this issue May 15, 2017
Merged
@wesleywiser
Copy link
Member

@est31 do you know if @moonheart08 is still interested in working on this? If not, I'd love to work on it.

@est31
Copy link
Member

est31 commented May 25, 2017

I have heard about them wanting to submit their changes it about a week ago or so. Lets wait one week more.

@wesleywiser
Copy link
Member

Ok, sounds good.

@lu-zero
Copy link
Contributor

lu-zero commented Jun 11, 2017

I implemented it as compiler plugin a while ago, maybe I could try to see how hard would be to move it in the right place?

https://github.com/lu-zero/compiler_error

@Geal
Copy link
Contributor

Geal commented Jun 11, 2017

FYI, there's a crate that does it as a compiler plugin, in the meantime: compiler_error
(for people like me who come to this issue and need it right now)

@wesleywiser wesleywiser mentioned this issue Jun 13, 2017
Merged
wesleywiser added a commit to wesleywiser/rust that referenced this issue Jun 19, 2017
@wesleywiser
Add compile_error!
0b29d26 
Related to rust-lang#40872
frewsxcv added a commit to frewsxcv/rust that referenced this issue Jun 21, 2017
@frewsxcv
Rollup merge of rust-lang#42620 - wesleywiser:compile_error, r=brson
d33e2c5 
Add compile_error!

Related to rust-lang#40872
@sfackler
Copy link
Member Author

The feature here is pretty straightforward, so let's stabilize it!

@rfcbot fcp merge

@rfcbot
Copy link

rfcbot commented Jul 13, 2017 •
edited by BurntSushi
Loading

Team member @sfackler has proposed to merge this. The next step is review by the rest of the tagged teams:

No concerns currently listed.

Once these reviewers reach consensus, this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rfcbot rfcbot added the proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. label Jul 13, 2017
@rfcbot
Copy link

rfcbot commented Jul 20, 2017

🔔 This is now entering its final comment period, as per the review above. 🔔

@rfcbot rfcbot added final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. and removed proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. labels Jul 20, 2017
@bors bors closed this as completed in 20b4f86 Jul 27, 2017
@wesleywiser wesleywiser mentioned this issue Aug 3, 2017
Merged
alexcrichton added a commit to alexcrichton/rust that referenced this issue Aug 12, 2017
@alexcrichton
Stabilize the compile_error_macro feature
febb255 
Stabilizes:

* `compile_error!` as a macro defined by rustc

Closes rust-lang#40872
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
B-RFC-approved Blocker: Approved by a merged RFC but not yet implemented. final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@Geal @lu-zero @wesleywiser @sfackler @est31 @rfcbot