Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ICH: IDs of items within a hir::Mod are not hashed #40876

Closed
michaelwoerister opened this issue Mar 28, 2017 · 0 comments
Closed

ICH: IDs of items within a hir::Mod are not hashed #40876

michaelwoerister opened this issue Mar 28, 2017 · 0 comments
Labels
A-incr-comp Area: Incremental compilation C-bug Category: This is a bug. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@michaelwoerister
Copy link
Member

This is not a problem at the moment but one could imagine it to become one because the data is available in the HIR map and in theory, decisions could be made based on it.
@michaelwoerister michaelwoerister added the A-incr-comp Area: Incremental compilation label Mar 28, 2017
@Mark-Simulacrum Mark-Simulacrum added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jun 20, 2017
@Mark-Simulacrum Mark-Simulacrum added the C-bug Category: This is a bug. label Jul 27, 2017
This was referenced Jul 2, 2018
Merged
Merged
bors added a commit that referenced this issue Jul 2, 2018
@bors
Auto merge of #51982 - michaelwoerister:hash-modules-properly, r=<try>
71ab10d 
incr.comp.: Take names of children into account when computing the ICH of a module's HIR.

Fixes #40876. Red-green tracking does not make this a problem anymore. We should verify this via a perf-run though.

r? @nikomatsakis
pietroalbini added a commit to pietroalbini/rust that referenced this issue Jul 3, 2018
@pietroalbini
Rollup merge of rust-lang#51982 - michaelwoerister:hash-modules-prope…
2346398 
…rly, r=nikomatsakis

incr.comp.: Take names of children into account when computing the ICH of a module's HIR.

Fixes rust-lang#40876. Red-green tracking does not make this a problem anymore. We should verify this via a perf-run though.

r? @nikomatsakis
pietroalbini added a commit to pietroalbini/rust that referenced this issue Jul 3, 2018
@pietroalbini
Rollup merge of rust-lang#51982 - michaelwoerister:hash-modules-prope…
b69058d 
…rly, r=nikomatsakis

incr.comp.: Take names of children into account when computing the ICH of a module's HIR.

Fixes rust-lang#40876. Red-green tracking does not make this a problem anymore. We should verify this via a perf-run though.

r? @nikomatsakis
@jebrosen jebrosen mentioned this issue Jun 1, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-incr-comp Area: Incremental compilation C-bug Category: This is a bug. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@michaelwoerister @Mark-Simulacrum