Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unique boxes #409

Closed
graydon opened this issue May 26, 2011 · 3 comments
Closed

Unique boxes #409

graydon opened this issue May 26, 2011 · 3 comments
Assignees
@brson
Labels
A-frontend Area: Compiler frontend (errors, parsing and HIR) A-typesystem Area: The type system
Milestone
0.1 first support...

Comments

@graydon
Copy link
Contributor

graydon commented May 26, 2011

Add a ~ box type (steal unary-bitwise-not, it's rare enough to live in a library or use ! as a synonym or something).

This will live in the tree kind, not permit shallow copies, only deep copies and move semantics.
@ghost ghost assigned pcwalton Jun 2, 2011
@pcwalton
Copy link
Contributor

Simple uses of ~ are working now.

@ghost ghost assigned brson Sep 20, 2011
brson added a commit that referenced this issue Sep 21, 2011
@brson
Parse unique box types
865dcb6 
Issue #409
brson added a commit that referenced this issue Sep 21, 2011
@brson
Make creation of unique boxes work again
7ae2517 
Issue #409
brson added a commit that referenced this issue Sep 21, 2011
@brson
Represent unique creation as a unop in the AST instead of its own expr
f809e22 
Like the box unop.

Issue #409
brson added a commit that referenced this issue Sep 21, 2011
@brson
Add ability to deref unique boxes. Make unique boxes immediates.
2cc01e2 
Issue #409
brson added a commit that referenced this issue Sep 22, 2011
@brson
Log and compare unique boxes
a993621 
Issue #409
brson added a commit that referenced this issue Sep 22, 2011
@brson
Call drop glue on the thing in a unique box
4d088bd 
Issue #409
brson added a commit that referenced this issue Sep 22, 2011
@brson
Convert ty::ty_uniq to contain a mutable type
1b3023e 
Issue #409
brson added a commit that referenced this issue Sep 22, 2011
@brson
Add support for mutable unique boxes
ea67099 
Issue #409
brson added a commit that referenced this issue Sep 22, 2011
@brson
Don't unify unique boxes with different mutability
f6ab12a 
Issue #409
brson added a commit that referenced this issue Sep 22, 2011
@brson
Factor alloc_uniq from trans_uniq
0f0ba33 
Issue #409
brson added a commit that referenced this issue Sep 22, 2011
@brson
Move uniq trans code to trans_uniq module
8492eed 
Issue #409
brson added a commit that referenced this issue Sep 22, 2011
@brson
Convert trans_uniq asserts to preconditions
5d5136d 
Issue #409
brson added a commit that referenced this issue Sep 22, 2011
@brson
Initialize unique box locals from other locals
268a9fe 
Issue #409
brson added a commit that referenced this issue Sep 22, 2011
@brson
Add assignment to unique box locals
67bac87 
Issue #409
brson added a commit that referenced this issue Sep 22, 2011
@brson
Add a test that assignment of unique boxes to locals does a copy
7c4fe10 
Issue #409
brson added a commit that referenced this issue Sep 22, 2011
@brson
Drop the previous value when copying one unique box local to another
3f41563 
Issue #409
brson added a commit that referenced this issue Sep 22, 2011
@brson
Add a test for unique boxes containing shared boxes
3bb7035 
Issue #409
brson added a commit that referenced this issue Sep 22, 2011
@brson
Add a test for unique boxes as fn args
1367f2b 
Issue #409
brson added a commit that referenced this issue Sep 22, 2011
@brson
Add a test for mutable references to unique boxes as function arguments
61a14f3 
Issue #409
brson added a commit that referenced this issue Sep 22, 2011
@brson
Calculate the correct kind for unique boxes
d174d91 
Issue #409
brson added a commit that referenced this issue Sep 22, 2011
@brson
Add tests for moving unique boxes
dff4986 
Issue #409
brson added a commit that referenced this issue Sep 22, 2011
@brson
Autoderef indexes and fields of unique boxes
30a4eab 
Issue #409
brson added a commit that referenced this issue Sep 23, 2011
@brson
Allow vectors to contain unique boxes. Closes #952
7a76323 
Issue #409
brson added a commit that referenced this issue Sep 23, 2011
@brson
Adda test for returning unique boxes
f628003 
Issue #409
brson added a commit that referenced this issue Sep 23, 2011
@brson
Remove nonsensical load and store from trans_uniq::copy_val
77fcab0 
Issue #409
brson added a commit that referenced this issue Sep 23, 2011
@brson
Add take glue for unique boxes
1a48023 
Closes #962
Issue #409
brson added a commit that referenced this issue Sep 23, 2011
@brson
Fix ty_uniq case in maybe_auto_unbox
0e5f76a 
Closes #961
Issue #409
@brson
Copy link
Contributor

brson commented Sep 23, 2011

Just some notes about things that need to be tested:

  • patterns
  • local destructuring
  • no copies in nested block expressions
  • sending
  • containing tuples
  • swap
  • unique boxes containing pinned types can't be copied

brson added a commit that referenced this issue Sep 23, 2011
@brson
Begin to support pattern matching on unique boxes
2082f67 
Issue #409
brson added a commit that referenced this issue Sep 23, 2011
@brson
Create a bunch of test cases for unique boxes by copying box tests
18b01d5 
XFAIL the ones that don't work

Issue #409
brson added a commit that referenced this issue Sep 23, 2011
@brson
Add two tests for sending unique boxes across channels
27972a6 
Issue #409
brson added a commit that referenced this issue Sep 23, 2011
@brson
Add missing case for pat_uniq to syntax::visit
122f714 
Issue #409
brson added a commit that referenced this issue Sep 23, 2011
@brson
Add let destructuring for unique boxes
d8f6e9f 
Issue #409
brson added a commit that referenced this issue Sep 24, 2011
@brson
Add tests for swapping unique boxes
9762972 
Issue #409
brson added a commit that referenced this issue Sep 24, 2011
@brson
Unique pointers containing pinned kinds become pinned
e5d5682 
Issue #409
brson added a commit that referenced this issue Sep 24, 2011
@brson
Support non-immediates in unique-box type glue
777a536 
Issue #409
brson added a commit that referenced this issue Sep 24, 2011
@brson
Tweak the type allocated for unique pointers
c587745 
Seems to be more correctish...

Issue #409
brson added a commit that referenced this issue Sep 24, 2011
@brson
Move a previous run-pass test for kind-lowered unique boxes to compil…
e804352 
…e-fail

This test tries to swap unique boxes containing resources, which is not
allowed.

Issue #409
brson added a commit that referenced this issue Sep 25, 2011
@brson
Support non-immediates in trans_uniq::copy_val
4f7ecce 
Issue #409
brson added a commit that referenced this issue Sep 25, 2011
@brson
Add a test for assignment of unique boxes of generics
895674b 
Closes #976

Issue #409
brson added a commit that referenced this issue Sep 26, 2011
@brson
Fix tags of unique boxes
389852b 
Issue #409
brson added a commit that referenced this issue Sep 27, 2011
@brson
Add a test that unique boxes in vectors are copied when the vector is
2d5e085 
Issue #409
brson added a commit that referenced this issue Sep 27, 2011
@brson
Don't allow copying of unique boxes of pinned kinds
4bee452 
Issue #409
@brson
Copy link
Contributor

brson commented Sep 29, 2011

Jesse hasn't fuzzed us any new bugs for this issue in several days so I think we're pretty solid here.

@brson brson closed this as completed Sep 29, 2011
keeperofdakeys pushed a commit to keeperofdakeys/rust that referenced this issue Dec 12, 2017
@bors
Auto merge of rust-lang#409 - jakllsch:netbsdlike-long-fixes, r=alexc…
fd06ed7 
…richton

Use correct type for c_ulong and c_long on 32-bit netbsdlike
Aaron1011 pushed a commit to Aaron1011/rust that referenced this issue Oct 26, 2020
@dependabot @bjorn3
Bump gimli from f30aeaa to 5763791 (rust-lang#409)
87d7b5c 
Bumps [gimli](https://github.com/gimli-rs/gimli) from `f30aeaa` to `5763791`.
- [Release notes](https://github.com/gimli-rs/gimli/releases)
- [Commits](gimli-rs/gimli@f30aeaa...5763791)

Signed-off-by: dependabot[bot] <support@dependabot.com>
ZuseZ4 pushed a commit to EnzymeAD/rust that referenced this issue Mar 7, 2023
@wsmoses
Improve Type Analysis (rust-lang#409)
06f7d22 
* Correct typetree lookup routine

* Additional fixes

* Improve TypeAnalysis performance

* error print
celinval pushed a commit to celinval/rust-dev that referenced this issue Jun 4, 2024
@bdalrhm @tedinski
Add support for manually passing options to examples. (rust-lang#409)
f651e5f 
* Add support for manually passing options to examples.

* Ignore files with `.props` extension.

* Use `WalkDir` instead of manually reading sub-directories.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brson brson

Labels
A-frontend Area: Compiler frontend (errors, parsing and HIR) A-typesystem Area: The type system
Projects
None yet
Milestone
0.1 first supported public release
Development

No branches or pull requests
3 participants
@graydon @brson @pcwalton