-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nonfatal rustdoc error on cssparser-macros #40978
Comments
|
Mark invalid Rust as text-only documentation. This avoids rust-lang/rust#40978. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-cssparser/131) <!-- Reviewable:end -->
I put a link in the tracking issue; I basically agree with @zackmdavis on both counts here. I see this has already been fixed upstream, but let's talk about if this is the actual behavior we want or not. |
@jdm: That's because every code block is considered being rust code and therefore is tested. Hoedown didn't consider such block as code blocks before, you just need to add |
Since this is expected, I'll close it. Don't hesitate to reopen it if I missed anything. |
The new markdown parser does not like this code block: https://github.com/servo/rust-cssparser/blob/20b509a7d3ca6c432281ebd00680bb0c3f5aadef/macros/lib.rs#L60-L67
I see:
The text was updated successfully, but these errors were encountered: