-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
incr.comp.: Lints and other error messages are not included in the ICH #41184
Labels
Comments
17 tasks
Mark-Simulacrum
added
C-enhancement
Category: An issue proposing an enhancement or a PR with one.
C-bug
Category: This is a bug.
and removed
C-enhancement
Category: An issue proposing an enhancement or a PR with one.
labels
Jul 27, 2017
This is not a problem anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Once #41141 lands, the compiler will compute the ICH for
TypeCheckTables
but when doing so, it will ignore thelints
field. This is not a problem yet since we currently still unconditionally re-run type checking in incremental mode -- but in the future this could lead to wrong or dropped linting messages.This should be addressed as part of refactoring the linting and error messaging system to better integrate with "on-demand" compilation.
The text was updated successfully, but these errors were encountered: