Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incr.comp.: Lints and other error messages are not included in the ICH #41184

Closed
michaelwoerister opened this issue Apr 10, 2017 · 2 comments
Closed
Labels
A-incr-comp Area: Incremental compilation C-bug Category: This is a bug.

Comments

@michaelwoerister
Copy link
Member

Once #41141 lands, the compiler will compute the ICH for TypeCheckTables but when doing so, it will ignore the lints field. This is not a problem yet since we currently still unconditionally re-run type checking in incremental mode -- but in the future this could lead to wrong or dropped linting messages.

This should be addressed as part of refactoring the linting and error messaging system to better integrate with "on-demand" compilation.

@nikomatsakis
Copy link
Contributor

See also #42511 (refactor lint handling to be more eager) and #42513 (capture diagnostic output in queries). I think we would ultimately be hashing the "diagnostic" structures, not the existing lint stuff (as described in #42513).

@Mark-Simulacrum Mark-Simulacrum added C-enhancement Category: An issue proposing an enhancement or a PR with one. C-bug Category: This is a bug. and removed C-enhancement Category: An issue proposing an enhancement or a PR with one. labels Jul 27, 2017
@michaelwoerister
Copy link
Member Author

This is not a problem anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-incr-comp Area: Incremental compilation C-bug Category: This is a bug.
Projects
None yet
Development

No branches or pull requests

3 participants